Bug 179299 - [Win] Layout Test fast/html/menuitem-element.html is failing.
Summary: [Win] Layout Test fast/html/menuitem-element.html is failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on: 183487
Blocks:
  Show dependency tree / graph
 
Reported: 2017-11-05 12:27 PST by Per Arne Vollan
Modified: 2018-03-13 10:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.70 KB, patch)
2018-03-12 18:54 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (manual) (7.66 KB, patch)
2018-03-13 08:10 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (manual) (7.66 KB, patch)
2018-03-13 08:12 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-11-05 12:27:20 PST 
The following layout test is failing on Windows:

fast/html/menuitem-element.html
Comment 1 Per Arne Vollan 2017-11-05 12:33:47 PST 
Updated test expectations in <https://trac.webkit.org/changeset/224470/webkit>.
Comment 2 Ross Kirsling 2018-03-01 15:13:27 PST 
(Original ticket: https://bugs.webkit.org/show_bug.cgi?id=179020)

I was going to address this, but it appears that TestOptions is purely ObjC in spite of being in DRT root:
https://github.com/WebKit/webkit/blob/master/Tools/DumpRenderTree/TestOptions.h

Seems like that ought to be dealt with first?
Comment 3 Ross Kirsling 2018-03-12 18:54:49 PDT 
Created attachment 335671 [details]
Patch
Comment 4 Ross Kirsling 2018-03-13 08:10:08 PDT 
Created attachment 335695 [details]
Patch (manual)

Resubmitting patch now that WinCairo build has restabilized.
Comment 5 Ross Kirsling 2018-03-13 08:12:13 PDT 
Created attachment 335696 [details]
Patch (manual)
Comment 6 Per Arne Vollan 2018-03-13 09:50:41 PDT 
Comment on attachment 335696 [details]
Patch (manual)

R=me.
Comment 7 WebKit Commit Bot 2018-03-13 10:16:32 PDT 
Comment on attachment 335696 [details]
Patch (manual)

Clearing flags on attachment: 335696

Committed r229578: <https://trac.webkit.org/changeset/229578>
Comment 8 WebKit Commit Bot 2018-03-13 10:16:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-03-13 10:17:18 PDT 
<rdar://problem/38421390>