Bug 179292 - REGRESSION (r221338): Web Inspector: NavigationBar incorrectly calculates minimumWidth
Summary: REGRESSION (r221338): Web Inspector: NavigationBar incorrectly calculates min...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
Keywords: InRadar
Depends on:
Blocks: 174229
  Show dependency treegraph
Reported: 2017-11-04 17:47 PDT by Nikita Vasilyev
Modified: 2017-11-15 12:11 PST (History)
4 users (show)

See Also:

Patch (1.54 KB, patch)
2017-11-04 17:51 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-11-04 17:47:59 PDT
Regressed in http://trac.webkit.org/changeset/221338 (is there a way to link to the particular line on that Trac page?)


    let totalItemWidth = this._visibleNavigationItems.reduce((total, item) => item.minimumWidth, 0);

totalItemWidth here is always minimumWidth of the last item.
Comment 1 Nikita Vasilyev 2017-11-04 17:51:50 PDT
Created attachment 326054 [details]
Comment 2 Nikita Vasilyev 2017-11-05 13:06:36 PST
This regression had no user impact in US English localization because WI.Sidebar.AbsoluteMinimumWidth of 200px provided sufficient width to fit all navigation items in our sidebars. There could have been issues with other localizations.
Comment 3 Devin Rousso 2017-11-05 22:45:00 PST
Comment on attachment 326054 [details]

Comment 4 WebKit Commit Bot 2017-11-05 23:04:05 PST
Comment on attachment 326054 [details]

Clearing flags on attachment: 326054

Committed r224481: <https://trac.webkit.org/changeset/224481>
Comment 5 WebKit Commit Bot 2017-11-05 23:04:06 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:11:32 PST