RESOLVED FIXED 179282
[LayoutState cleanup] Move m_layoutState from RenderView to LayoutContext 
https://bugs.webkit.org/show_bug.cgi?id=179282
Summary [LayoutState cleanup] Move m_layoutState from RenderView to LayoutContext
zalan
Reported 2017-11-03 22:02:57 PDT
It does not really belong to RenderView.
Attachments
Patch (81.93 KB, patch)
2017-11-04 22:20 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (82.34 KB, patch)
2017-11-06 19:34 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-03 22:03:30 PDT
<rdar://problem/35348653>
zalan
Comment 2 2017-11-04 22:20:40 PDT
Created attachment 326058 [details] Patch
Build Bot
Comment 3 2017-11-04 22:23:38 PDT
Attachment 326058 [details] did not pass style-queue: ERROR: Source/WebCore/style/RenderTreeUpdaterFirstLetter.cpp:223: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/style/RenderTreeUpdaterListItem.cpp:74: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 4 2017-11-06 08:50:28 PST
Comment on attachment 326058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326058&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:741 > + bool paginated = view().frameView().layoutContext().layoutState()->isPaginated(); If this wasn't temporary we'd want layoutState() helper.
WebKit Commit Bot
Comment 5 2017-11-06 09:45:13 PST
Comment on attachment 326058 [details] Patch Clearing flags on attachment: 326058 Committed r224494: <https://trac.webkit.org/changeset/224494>
WebKit Commit Bot
Comment 6 2017-11-06 09:45:15 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 7 2017-11-06 12:59:21 PST
This change appears to have caused flakiness with LayoutTests in the fast/repaint directory on WK1. Example of failures: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224495%20(4699)/results.html
Ryan Haddad
Comment 8 2017-11-06 13:00:25 PST
(In reply to Ryan Haddad from comment #7) > This change appears to have caused flakiness with LayoutTests in the > fast/repaint directory on WK1. Example of failures: > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224495%20(4699)/results.html I can repro locally with a build of r224494 with the following command: run-webkit-tests -1 fast/repaint/transform-table-layout.html fast/repaint/focus-ring-repaint.html --iter 200 --no-retry-failure
Ryan Haddad
Comment 9 2017-11-06 13:44:40 PST
Reverted r224494 for reason: Introduced LayoutTest flakiness on WK1. Committed r224511: <https://trac.webkit.org/changeset/224511>
zalan
Comment 10 2017-11-06 19:34:43 PST
Created attachment 326183 [details] Patch
Build Bot
Comment 11 2017-11-06 19:36:10 PST
Attachment 326183 [details] did not pass style-queue: ERROR: Source/WebCore/style/RenderTreeUpdaterFirstLetter.cpp:223: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/style/RenderTreeUpdaterListItem.cpp:74: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 12 2017-11-06 19:39:04 PST
(In reply to Ryan Haddad from comment #9) > Reverted r224494 for reason: > > Introduced LayoutTest flakiness on WK1. > > Committed r224511: <https://trac.webkit.org/changeset/224511> Fixed. + : m_clipped(false)
WebKit Commit Bot
Comment 13 2017-11-06 20:10:03 PST
Comment on attachment 326183 [details] Patch Clearing flags on attachment: 326183 Committed r224529: <https://trac.webkit.org/changeset/224529>
WebKit Commit Bot
Comment 14 2017-11-06 20:10:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.