Bug 179279 – [LayoutState cleanup] Move offset/cliprect/pagination code to dedicated methods

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

ssia.

[Radar WebKit Bug Importer]

<rdar://problem/35348171>

[alan]

Created attachment 326006 [details]
Patch

[Antti Koivisto]

Comment on attachment 326006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326006&action=review

> Source/WebCore/rendering/LayoutState.h:86
> +    void computeOffsets(RenderBox&, LayoutSize offset);
> +    void computeClipRect(RenderBox&);
> +    void computePaginationInformation(RenderBox&, LayoutUnit pageLogicalHeight, bool pageLogicalHeightChanged);

It would be nice if compute* methods would return the results instead of mutating the object state (they could be const). This might be something to consider in future.

[alan]

Created attachment 326043 [details]
Patch

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 326006 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326006&action=review
> 
> > Source/WebCore/rendering/LayoutState.h:86
> > +    void computeOffsets(RenderBox&, LayoutSize offset);
> > +    void computeClipRect(RenderBox&);
> > +    void computePaginationInformation(RenderBox&, LayoutUnit pageLogicalHeight, bool pageLogicalHeightChanged);
> 
> It would be nice if compute* methods would return the results instead of
> mutating the object state (they could be const). This might be something to
> consider in future.
Good idea!

[WebKit Commit Bot]

Comment on attachment 326043 [details]
Patch

Clearing flags on attachment: 326043

Committed r224460: <https://trac.webkit.org/changeset/224460>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.