Bug 179272 – LayoutState should take RenderBox reference.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

instead of RenderBox*

[Radar WebKit Bug Importer]

<rdar://problem/35345247>

[zalan]

Created attachment 325984 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 325984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325984&action=review

> Source/WebCore/rendering/LayoutState.h:124
> -    RenderObject* m_renderer { nullptr };
> +    RenderElement* m_root { nullptr };

Isn't this the current renderer (the one associated with this state), not the root?

[zalan]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 325984 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325984&action=review
> 
> > Source/WebCore/rendering/LayoutState.h:124
> > -    RenderObject* m_renderer { nullptr };
> > +    RenderElement* m_root { nullptr };
> 
> Isn't this the current renderer (the one associated with this state), not
> the root?
It's the root of the LayoutState, but it indeed could be confusing. I'll revert it back to renderer.

[zalan]

Created attachment 325999 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 325999 [details]
Patch

Clearing flags on attachment: 325999

Committed r224455: <https://trac.webkit.org/changeset/224455>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.