Bug 179250 - Requests handled by Service Worker should not go through preflighting
Summary: Requests handled by Service Worker should not go through preflighting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-03 11:27 PDT by youenn fablet
Modified: 2017-11-15 12:23 PST (History)
8 users (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2017-11-03 11:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Build fix (2.30 KB, patch)
2017-11-03 14:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-11-03 11:27:17 PDT 
DocumentThreadableLoader is using preflight for any non simple CORS request.
In case request is handled by SW, no preflighting should happen.
If SW is not handling the request, preflighting should happen.
Comment 1 youenn fablet 2017-11-03 11:45:09 PDT 
Created attachment 325928 [details]
Patch
Comment 2 youenn fablet 2017-11-03 14:45:25 PDT 
Created attachment 325964 [details]
Build fix
Comment 3 Alex Christensen 2017-11-03 15:11:11 PDT 
Do we intend to always not allow requests that would require preflight?  Why?
Comment 4 Alex Christensen 2017-11-03 15:22:16 PDT 
Comment on attachment 325928 [details]
Patch

We really ought to move preflight to the right place.
Comment 5 WebKit Commit Bot 2017-11-03 16:09:31 PDT 
Comment on attachment 325928 [details]
Patch

Clearing flags on attachment: 325928

Committed r224439: <https://trac.webkit.org/changeset/224439>
Comment 6 WebKit Commit Bot 2017-11-03 16:09:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 12:23:52 PST 
<rdar://problem/35567451>