Bug 179247 – [JSC][JIT] Clean up SlowPathCall stubs

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC][JIT] Clean up SlowPathCall stubs

[Yusuke Suzuki]

Created attachment 325916 [details]
Patch

[Saam Barati]

Comment on attachment 325916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325916&action=review

nice cleanup. r=me

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:283
> +SLOW_PATH_DECL(slow_path_check_tdz)
> +{
> +    BEGIN();
> +    THROW(createTDZError(exec));
> +}

Not a fan of this name, this used to be called throw_tdz_error or whatever, which I think is more intuitive.

[Saam Barati]

Comment on attachment 325916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325916&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        We have bunch of duplicate functions that just calls a slow path function.

calls => call

[Yusuke Suzuki]

Comment on attachment 325916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325916&action=review

Thanks

>> Source/JavaScriptCore/ChangeLog:8
>> +        We have bunch of duplicate functions that just calls a slow path function.
> 
> calls => call

Fixed!

>> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:283
>> +}
> 
> Not a fan of this name, this used to be called throw_tdz_error or whatever, which I think is more intuitive.

Currently, we rely on this name because we mechanically call slow_path function that has the same name to the opcode :(

[Yusuke Suzuki]

Committed r224626: <https://trac.webkit.org/changeset/224626>

[Radar WebKit Bug Importer]

<rdar://problem/35562220>