WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
179247
[JSC][JIT] Clean up SlowPathCall stubs
https://bugs.webkit.org/show_bug.cgi?id=179247
Summary
[JSC][JIT] Clean up SlowPathCall stubs
Yusuke Suzuki
Reported
2017-11-03 10:46:34 PDT
[JSC][JIT] Clean up SlowPathCall stubs
Attachments
Patch
(33.34 KB, patch)
2017-11-03 10:47 PDT
,
Yusuke Suzuki
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2017-11-03 10:47:58 PDT
Created
attachment 325916
[details]
Patch
Saam Barati
Comment 2
2017-11-08 10:49:12 PST
Comment on
attachment 325916
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=325916&action=review
nice cleanup. r=me
> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:283 > +SLOW_PATH_DECL(slow_path_check_tdz) > +{ > + BEGIN(); > + THROW(createTDZError(exec)); > +}
Not a fan of this name, this used to be called throw_tdz_error or whatever, which I think is more intuitive.
Saam Barati
Comment 3
2017-11-08 10:49:35 PST
Comment on
attachment 325916
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=325916&action=review
> Source/JavaScriptCore/ChangeLog:8 > + We have bunch of duplicate functions that just calls a slow path function.
calls => call
Yusuke Suzuki
Comment 4
2017-11-09 07:14:26 PST
Comment on
attachment 325916
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=325916&action=review
Thanks
>> Source/JavaScriptCore/ChangeLog:8 >> + We have bunch of duplicate functions that just calls a slow path function. > > calls => call
Fixed!
>> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:283 >> +} > > Not a fan of this name, this used to be called throw_tdz_error or whatever, which I think is more intuitive.
Currently, we rely on this name because we mechanically call slow_path function that has the same name to the opcode :(
Yusuke Suzuki
Comment 5
2017-11-09 07:16:30 PST
Committed
r224626
: <
https://trac.webkit.org/changeset/224626
>
Radar WebKit Bug Importer
Comment 6
2017-11-15 09:41:01 PST
<
rdar://problem/35562220
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug