Bug 179243 – Add CPU(UNKNOWN) to cover all the unknown CPU types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

Add CPU(UNKNOWN) to absorb all the unknown CPU types

[Yusuke Suzuki]

Created attachment 325894 [details]
Patch

[Build Bot]

Attachment 325894 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/InlineASM.h:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

This patch's intent is dropping listing so many CPUs. They should be covered as CPU(UNKNOWN). This approach is good for the future CPU addition. If your CPU breaks CPU(UNKNOWN)'s conservative assumption, you should add it as a new CPU.

[Yusuke Suzuki]

Created attachment 325899 [details]
Patch

[Build Bot]

Attachment 325899 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/InlineASM.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 325900 [details]
Patch

[Build Bot]

Attachment 325900 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/InlineASM.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 325901 [details]
Patch

[Build Bot]

Attachment 325901 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/InlineASM.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Comment on attachment 325901 [details]
Patch

Let's fix things and remove HPPA!

[Yusuke Suzuki]

Created attachment 327340 [details]
Patch

[Yusuke Suzuki]

Created attachment 327341 [details]
Patch

[Yusuke Suzuki]

Let's drop bunch of minor CPUs without dropping their support :D

[EWS Watchlist]

Attachment 327341 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/InlineASM.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[JF Bastien]

Comment on attachment 327341 [details]
Patch

This will potentially break stuff, are there folks who care about these architectures who need a heads up?

Otherwise r=me

[Yusuke Suzuki]

(In reply to JF Bastien from comment #15)
> Comment on attachment 327341 [details]
> Patch
> 
> This will potentially break stuff, are there folks who care about these
> architectures who need a heads up?
> 
> Otherwise r=me

I think dropped architectures (ALPHA, HPPA, IA64, SH4, S390X, S390) are not maintained by WebKit folks. They continue to work. But explicit defines are removed and handled as CPU(UNKNOWN). I'll send a mail to webkit-dev for a heads-up.

[Yusuke Suzuki]

Committed r225040: <https://trac.webkit.org/changeset/225040>

[Radar WebKit Bug Importer]

<rdar://problem/35639446>