Bug 179238 - Use WK_IOS_TBA instead of WK_MAC_TBA to indicate availability of private functions on iOS
Summary: Use WK_IOS_TBA instead of WK_MAC_TBA to indicate availability of private func...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-03 04:44 PDT by Frédéric Wang (:fredw)
Modified: 2017-11-15 12:14 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2017-11-03 04:45 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2017-11-03 07:50 PDT, Frédéric Wang (:fredw)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-11-03 04:44:13 PDT
The changes happened in r224057 and r223207. Also I recently upgraded Xcode. These are the errors I get:

/Users/fred/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests
.mm:63:11: error: 
      '_requestActiveNowPlayingSessionInfo:' is unavailable: not available on
      iOS
    [self _requestActiveNowPlayingSessionInfo:completionHandler];
          ^
In file included from /Users/fred/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:32:
/Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebViewPrivate.h:439:1: note: 
      '_requestActiveNowPlayingSessionInfo:' has been explicitly marked
      unavailable here
- (void)_requestActiveNowPlayingSessionInfo:(void(^)(BOOL, NSString*, do...
^
1 error generated.

/Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:84:27: er
ror: 
      '_setCacheStoragePerOriginQuota:' is unavailable: not available on iOS
    [poolWebsiteDataStore _setCacheStoragePerOriginQuota: 400 * 1024];
                          ^
In file included from /Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:46:
/Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:48:74: note: 
      property '_cacheStoragePerOriginQuota' is declared unavailable here
  ...(nonatomic, setter=_setCacheStoragePerOriginQuota:) NSUInteger _cacheSto...
                                                                    ^
/Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:48:74: note: 
      '_setCacheStoragePerOriginQuota:' has been explicitly marked unavailable
      here
/Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:87:31: error: 
      '_setCacheStorageDirectory:' is unavailable: not available on iOS
        [poolWebsiteDataStore _setCacheStorageDirectory: cacheStorageDirectory];
                              ^
In file included from /Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:46:
/Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:49:68: note: 
      property '_cacheStorageDirectory' is declared unavailable here
@property (nonatomic, setter=_setCacheStorageDirectory:) NSString* _cach...
                                                                   ^
/Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:49:68: note: 
      '_setCacheStorageDirectory:' has been explicitly marked unavailable here
2 errors generated.
Comment 1 Frédéric Wang (:fredw) 2017-11-03 04:45:50 PDT
Created attachment 325882 [details]
Patch

This patch fixes the build errors, but I have no ideas whether it is correct.
Comment 2 Ali Juma 2017-11-03 06:36:24 PDT
Is the problem that on lines 48 and 49 of WKWebsiteDataStorePrivate.h, the ios version is set to WK_MAC_TBA instead of WK_IOS_TBA?
Comment 3 Frédéric Wang (:fredw) 2017-11-03 07:50:05 PDT
Created attachment 325893 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2017-11-03 08:11:10 PDT
Committed r224396: <https://trac.webkit.org/changeset/224396>
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:14:30 PST
<rdar://problem/35567189>