Bug 179219 - [WinCairo] LayoutTests doesn't read TextExpectations files correctly
Summary: [WinCairo] LayoutTests doesn't read TextExpectations files correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 179216
  Show dependency tree / graph
 
Reported: 2017-11-02 17:29 PDT by Basuke Suzuki
Modified: 2017-11-15 09:41 PST (History)
11 users (show)

See Also:

Attachments
patch (3.75 KB, patch)
2017-11-09 14:49 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
fix webkit-testpy failures (4.11 KB, patch)
2017-11-09 16:34 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-11-02 17:29:26 PDT 
It runs entire files on Windows if it runs from CommandPrompt or PowerShell.
Comment 1 Basuke Suzuki 2017-11-02 17:31:14 PDT 
It seems test_expectations.py:
TestExpectationsParser::_collect_matching_tests() just compare strings with no care about path delimiter.
Comment 2 Basuke Suzuki 2017-11-09 14:40:01 PST 
TestConfigulation are created incorrectly. That's the reason each tests matching to skip expectations are treated as 'PASS'.
Comment 3 Basuke Suzuki 2017-11-09 14:49:31 PST 
Created attachment 326491 [details]
patch
Comment 4 Basuke Suzuki 2017-11-09 14:50:43 PST 
Comment on attachment 326491 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326491&action=review

> Tools/Scripts/webkitpy/port/apple.py:-92
> -        allowed_port_names = self.VERSION_FALLBACK_ORDER + [self.operating_system() + "-future"]

This line is not used.

> Tools/Scripts/webkitpy/port/apple.py:125
> +        for port_name in self._allowed_port_names():

extract this list generation for easy refactoring.
Comment 5 Basuke Suzuki 2017-11-09 16:34:02 PST 
Created attachment 326508 [details]
fix webkit-testpy  failures
Comment 6 WebKit Commit Bot 2017-11-10 16:20:34 PST 
Comment on attachment 326508 [details]
fix webkit-testpy  failures

Clearing flags on attachment: 326508

Committed r224714: <https://trac.webkit.org/changeset/224714>
Comment 7 WebKit Commit Bot 2017-11-10 16:20:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-11-15 09:41:33 PST 
<rdar://problem/35562239>