Bug 179213 - Add basic OffscreenCanvas interface
Summary: Add basic OffscreenCanvas interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-02 16:59 PDT by Dean Jackson
Modified: 2017-11-03 11:06 PDT (History)
10 users (show)

See Also:

Attachments
Patch (20.97 KB, patch)
2017-11-02 17:04 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (21.44 KB, patch)
2017-11-02 17:10 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.46 MB, application/zip)
2017-11-02 18:11 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews103 for mac-elcapitan (1.10 MB, application/zip)
2017-11-02 18:11 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.89 MB, application/zip)
2017-11-02 18:22 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1.01 MB, application/zip)
2017-11-02 18:36 PDT, Build Bot 		no flags Details
Patch (22.20 KB, patch)
2017-11-02 19:03 PDT, Dean Jackson 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-11-02 16:59:41 PDT 
Add basic OffscreenCanvas interface
Comment 1 Radar WebKit Bug Importer 2017-11-02 17:00:45 PDT 
<rdar://problem/35326778>
Comment 2 Dean Jackson 2017-11-02 17:04:07 PDT 
Created attachment 325798 [details]
Patch
Comment 3 Dean Jackson 2017-11-02 17:10:09 PDT 
Created attachment 325800 [details]
Patch
Comment 4 Sam Weinig 2017-11-02 17:46:46 PDT 
Comment on attachment 325800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325800&action=review

> Source/WebCore/html/OffscreenCanvas.cpp:66
> +}
> +
> +

Extra newline :)

> Source/WebCore/html/OffscreenCanvas.idl:34
> +enum OffscreenRenderingContextType
> +{

{ should be on the previous line.
Comment 5 Build Bot 2017-11-02 18:11:03 PDT 
Comment on attachment 325800 [details]
Patch

Attachment 325800 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5082586

New failing tests:
fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html
Comment 6 Build Bot 2017-11-02 18:11:04 PDT 
Created attachment 325809 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-11-02 18:11:48 PDT 
Comment on attachment 325800 [details]
Patch

Attachment 325800 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5082682

New failing tests:
fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html
Comment 8 Build Bot 2017-11-02 18:11:49 PDT 
Created attachment 325810 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-11-02 18:22:50 PDT 
Comment on attachment 325800 [details]
Patch

Attachment 325800 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5082663

New failing tests:
fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html
Comment 10 Build Bot 2017-11-02 18:22:52 PDT 
Created attachment 325811 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-11-02 18:36:25 PDT 
Comment on attachment 325800 [details]
Patch

Attachment 325800 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5082851

New failing tests:
fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html
Comment 12 Build Bot 2017-11-02 18:36:26 PDT 
Created attachment 325816 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 13 Dean Jackson 2017-11-02 19:03:39 PDT 
Created attachment 325818 [details]
Patch
Comment 14 Dean Jackson 2017-11-02 19:04:53 PDT 
Comment on attachment 325818 [details]
Patch

Checking EWS.
Comment 15 Dean Jackson 2017-11-03 11:06:14 PDT 
Committed r224407: <https://trac.webkit.org/changeset/224407>