Bug 179206 – RenderObject::*positioned() naming cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

+isFixedPositioned()
+isAbsolutePositioned()
isRelPositioned() -> isRelativePositioned()

[Radar WebKit Bug Importer]

<rdar://problem/35325254>

[zalan]

Created attachment 325788 [details]
Patch

[Darin Adler]

Comment on attachment 325788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325788&action=review

> Source/WebCore/rendering/RenderObject.h:421
> +    bool isAbsolutePositioned() const { return isOutOfFlowPositioned() && style().position() == AbsolutePosition; }

The CSS specification calls this "is absolutely positioned", not "is absolute positioned", and I think the former is better grammar.

> Source/WebCore/rendering/RenderObject.h:422
> +    bool isRelativePositioned() const { return m_bitfields.isRelativePositioned(); }

The CSS specification calls this "is relatively positioned", as opposed to "is relative positioned", and I think the former is better grammar.

> Source/WebCore/rendering/RenderObject.h:423
>      bool isStickyPositioned() const { return m_bitfields.isStickyPositioned(); }

The CSS specification calls this "is stickily positioned", as opposed to "is sticky positioned", and I think the former is better grammar.

> Source/WebCore/rendering/RenderObject.h:859
> -            IsStaticallyPositioned = 0,
> -            IsRelativelyPositioned = 1,
> +            IsStaticPositioned = 0,
> +            IsRelativePositioned = 1,

I think the old names here are better than the new ones, grammatically speaking.

[zalan]

Created attachment 325906 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 325906 [details]
Patch

isFixedPositioned vs isStickilyPositioned etc read awkwardly. Maybe it should be isPositionFixed(), isPositionRelative()?

[WebKit Commit Bot]

Comment on attachment 325906 [details]
Patch

Clearing flags on attachment: 325906

Committed r224404: <https://trac.webkit.org/changeset/224404>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.