Bug 179203 - Remove pointer caging for HashMapImpl, JSLexicalEnvironment, DirectArguments, ScopedArguments, and ScopedArgumentsTable
Summary: Remove pointer caging for HashMapImpl, JSLexicalEnvironment, DirectArguments,...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-02 14:57 PDT by Saam Barati
Modified: 2017-11-15 09:43 PST (History)
13 users (show)

See Also:

Attachments
patch (9.03 KB, patch)
2017-11-08 15:17 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (10.33 KB, patch)
2017-11-13 20:07 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-11-02 14:57:13 PDT 
We'll still allocate them from the caged area, but we won't emit code to do caging when loading/storing to them. Example of types we'll remove this from are scopes and hash maps.
Comment 1 Saam Barati 2017-11-08 15:17:19 PST 
Created attachment 326392 [details]
patch

Going to do some local perf testing before I put it up for review.
Comment 2 Yusuke Suzuki 2017-11-09 07:10:27 PST 
I remember some benchmarks in kraken or octane are regressed with this caging.
Comment 3 Saam Barati 2017-11-13 20:07:11 PST 
Created attachment 326842 [details]
patch
Comment 4 Yusuke Suzuki 2017-11-13 20:32:33 PST 
Comment on attachment 326842 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2017-11-13 21:33:33 PST 
Comment on attachment 326842 [details]
patch

Clearing flags on attachment: 326842

Committed r224802: <https://trac.webkit.org/changeset/224802>
Comment 6 WebKit Commit Bot 2017-11-13 21:33:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:43:00 PST 
<rdar://problem/35562296>