RESOLVED FIXED 179203
Remove pointer caging for HashMapImpl, JSLexicalEnvironment, DirectArguments, ScopedArguments, and ScopedArgumentsTable 
https://bugs.webkit.org/show_bug.cgi?id=179203
Summary Remove pointer caging for HashMapImpl, JSLexicalEnvironment, DirectArguments,...
Saam Barati
Reported 2017-11-02 14:57:13 PDT
We'll still allocate them from the caged area, but we won't emit code to do caging when loading/storing to them. Example of types we'll remove this from are scopes and hash maps.
Attachments
patch (9.03 KB, patch)
2017-11-08 15:17 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (10.33 KB, patch)
2017-11-13 20:07 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-11-08 15:17:19 PST
Created attachment 326392 [details] patch Going to do some local perf testing before I put it up for review.
Yusuke Suzuki
Comment 2 2017-11-09 07:10:27 PST
I remember some benchmarks in kraken or octane are regressed with this caging.
Saam Barati
Comment 3 2017-11-13 20:07:11 PST
Created attachment 326842 [details] patch
Yusuke Suzuki
Comment 4 2017-11-13 20:32:33 PST
Comment on attachment 326842 [details] patch r=me
WebKit Commit Bot
Comment 5 2017-11-13 21:33:33 PST
Comment on attachment 326842 [details] patch Clearing flags on attachment: 326842 Committed r224802: <https://trac.webkit.org/changeset/224802>
WebKit Commit Bot
Comment 6 2017-11-13 21:33:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:43:00 PST
<rdar://problem/35562296>
Note You need to log in before you can comment on or make changes to this bug.