179191 – Import 2dcontext Web Platform Tests

Bug 179191 - Import 2dcontext Web Platform Tests

Summary: Import 2dcontext Web Platform Tests

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Chris Lord

URL:
Keywords:	InRadar

Depends on:
Blocks:	183720 202455 202457 202458 202459 202460 202516 202517 202518 202523 182686
	Show dependency tree / graph

Reported:	2017-11-02 12:30 PDT by Dean Jackson
Modified:	2019-10-04 11:45 PDT (History)
CC List:	18 users (show)

See Also:

Attachments
Patch (3.91 MB, patch) 2017-11-02 12:39 PDT, Dean Jackson	no flags	Details \| Formatted Diff \| Diff
Patch for landing (3.91 MB, patch) 2017-11-02 13:49 PDT, Dean Jackson	no flags	Details \| Formatted Diff \| Diff
Patch (7.01 MB, patch) 2019-10-01 04:52 PDT, Chris Lord	no flags	Details \| Formatted Diff \| Diff
Patch (8.20 MB, patch) 2019-10-02 07:05 PDT, Chris Lord	no flags	Details \| Formatted Diff \| Diff
Patch (8.20 MB, patch) 2019-10-02 08:41 PDT, Chris Lord	no flags	Details \| Formatted Diff \| Diff
Patch (3.37 MB, patch) 2019-10-03 02:54 PDT, Chris Lord	no flags	Details \| Formatted Diff \| Diff
Patch (3.37 MB, patch) 2019-10-03 03:47 PDT, Chris Lord	no flags	Details \| Formatted Diff \| Diff
Patch (3.37 MB, patch) 2019-10-03 06:54 PDT, Chris Lord	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dean Jackson 2017-11-02 12:30:17 PDT

Import OffscreenCanvas Web Platform Tests

Comment 1 Radar WebKit Bug Importer 2017-11-02 12:31:25 PDT

<rdar://problem/35320416>

Comment 2 Dean Jackson 2017-11-02 12:39:42 PDT

Created attachment 325750 [details]
Patch

Comment 3 Dean Jackson 2017-11-02 13:49:00 PDT

Created attachment 325764 [details]
Patch for landing

Comment 4 Chris Lord 2019-10-01 04:52:04 PDT

Created attachment 379893 [details]
Patch

Comment 5 youenn fablet 2019-10-01 04:57:54 PDT

Comment on attachment 379893 [details]
Patch

r=me if bots are happy.
If it proves difficult to have bots happy, you could try splitting the patch in 2dcontext and offlinecanvas.

Comment 6 Chris Lord 2019-10-02 06:13:22 PDT

I realised this patch missed setting the baseline for the offscreen-canvas tests (whoops!) - I'm just in the process of investigating the platform differences and filing the relevant bugs, it'll likely take a few more EWS submissions to get this green.

Comment 7 Chris Lord 2019-10-02 07:05:51 PDT

Created attachment 380016 [details]
Patch

Comment 8 Chris Lord 2019-10-02 08:41:03 PDT

Created attachment 380024 [details]
Patch

Comment 9 Aakash Jain 2019-10-02 11:13:38 PDT

Since this is a large patch (8 mb), svn-apply is taking very long time to apply this patch (2+ hours on some bots, e.g.: https://ews-build.webkit.org/#/builders/7/builds/10606).

I cancelled the build on 'style' queue so that other patches can be processed, will retry it later when the bot is relatively free.

Comment 10 Chris Lord 2019-10-02 12:21:24 PDT

(In reply to Aakash Jain from comment #9)
> Since this is a large patch (8 mb), svn-apply is taking very long time to
> apply this patch (2+ hours on some bots, e.g.:
> https://ews-build.webkit.org/#/builders/7/builds/10606).
> 
> I cancelled the build on 'style' queue so that other patches can be
> processed, will retry it later when the bot is relatively free.

Thanks - I think for future revisions, I'll split this patch into the offscreen-canvas tests and the 2dcontext tests - though I think the size of the latter may be the larger part of this patch...

Comment 11 Chris Lord 2019-10-03 02:54:59 PDT

Created attachment 380094 [details]
Patch

Comment 12 Chris Lord 2019-10-03 03:47:10 PDT

Created attachment 380098 [details]
Patch

Comment 13 Chris Lord 2019-10-03 06:54:26 PDT

Created attachment 380108 [details]
Patch

Comment 14 Chris Lord 2019-10-03 06:56:04 PDT

I believe this latest test will be green, so I'm marking it for review/committing. I'll hold off on bug 202513 until this lands.

Comment 15 WebKit Commit Bot 2019-10-04 02:52:53 PDT

Comment on attachment 380108 [details]
Patch

Clearing flags on attachment: 380108

Committed r250714: <https://trac.webkit.org/changeset/250714>

Comment 16 WebKit Commit Bot 2019-10-04 02:52:55 PDT

All reviewed patches have been landed.  Closing bug.

Comment 17 Truitt Savell 2019-10-04 11:45:24 PDT

The new test imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round.html

Is failing on Mojave+

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2F2dcontext%2Fline-styles%2F2d.line.cap.round.html

Diff:
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r250730%20(7141)/imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round-diff.txt