Bug 179172 - Implement FrameView::did[Start|End|Update]Scroll for subframes
Summary: Implement FrameView::did[Start|End|Update]Scroll for subframes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 149264
  Show dependency treegraph
Reported: 2017-11-02 08:22 PDT by Frédéric Wang (:fredw)
Modified: 2019-07-10 09:10 PDT (History)
3 users (show)

See Also:

Patch (not tested) (2.40 KB, patch)
2017-11-02 08:24 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-11-02 08:22:32 PDT
While analyzing the difference between overflow node and subframes, I noticed that frame views don't do anything special for FrameView::didStartScroll, FrameView::didEndScroll and FrameView::didUpdateScroll, contrary to overflow layers. I am not sure whether it is actually needed for subframes? Moreoever for overflow node, it seems that it is only used when ENABLE_TOUCH_EVENTS is enabled which I can not try without the private iOS SDK (bug 179167).
Comment 1 Frédéric Wang (:fredw) 2017-11-02 08:24:16 PDT
Created attachment 325715 [details]
Patch (not tested)
Comment 2 Frédéric Wang (:fredw) 2019-07-10 03:51:15 PDT
@Antti: Do you think this is actually something we need?
Comment 3 Simon Fraser (smfr) 2019-07-10 09:10:00 PDT
I don't think we need this patch.