179163 – Use CompletionHandlers for redirects

RESOLVED FIXED 179163

Use CompletionHandlers for redirects

https://bugs.webkit.org/show_bug.cgi?id=179163

Summary Use CompletionHandlers for redirects

Alex Christensen

Reported 2017-11-02 00:58:14 PDT

Use CompletionHandlers for redirects

Attachments
Patch (62.35 KB, patch) 2017-11-02 01:01 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (63.78 KB, patch) 2017-11-02 09:37 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (63.78 KB, patch) 2017-11-02 10:15 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (64.86 KB, patch) 2017-11-02 12:37 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (64.89 KB, patch) 2017-11-02 13:08 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (65.93 KB, patch) 2017-11-02 13:12 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (67.27 KB, patch) 2017-11-02 13:31 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (66.17 KB, patch) 2017-11-02 13:59 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.29 MB, application/zip) 2017-11-02 14:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (941.35 KB, application/zip) 2017-11-02 15:07 PDT, Build Bot	no flags	Details
Patch (39.07 KB, patch) 2017-11-02 15:46 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (56.81 KB, patch) 2017-11-02 17:54 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (64.84 KB, patch) 2017-11-02 19:48 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (64.88 KB, patch) 2017-11-02 19:54 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2017-11-02 01:01:59 PDT

Created attachment 325697 [details] Patch

Alex Christensen

Comment 2 2017-11-02 09:37:11 PDT

Created attachment 325721 [details] Patch

Alex Christensen

Comment 3 2017-11-02 10:15:28 PDT

Created attachment 325728 [details] Patch

Alex Christensen

Comment 4 2017-11-02 12:37:28 PDT

Created attachment 325749 [details] Patch

Alex Christensen

Comment 5 2017-11-02 13:08:40 PDT

Created attachment 325758 [details] Patch

Alex Christensen

Comment 6 2017-11-02 13:12:10 PDT

Created attachment 325759 [details] Patch

Alex Christensen

Comment 7 2017-11-02 13:31:27 PDT

Created attachment 325761 [details] Patch

Alex Christensen

Comment 8 2017-11-02 13:59:40 PDT

Created attachment 325767 [details] patch

Tim Horton

Comment 9 2017-11-02 14:17:33 PDT

Comment on attachment 325767 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=325767&action=review CHANGELOG > Source/WebKit/ChangeLog:1 > +<<<<<<< .mine Plz no > Source/WebKit/ChangeLog:12 > + * NetworkProcess/Downloads/Download.h: Some of this is actual code change, why isn’t it explained!

Build Bot

Comment 10 2017-11-02 14:36:35 PDT

Comment on attachment 325767 [details] patch Attachment 325767 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5079972 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2017-11-02 14:36:36 PDT

Created attachment 325769 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 12 2017-11-02 15:07:01 PDT

Comment on attachment 325767 [details] patch Attachment 325767 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5080143 Number of test failures exceeded the failure limit.

Build Bot

Comment 13 2017-11-02 15:07:03 PDT

Created attachment 325774 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Alex Christensen

Comment 14 2017-11-02 15:46:08 PDT

Created attachment 325784 [details] Patch

Alex Christensen

Comment 15 2017-11-02 17:54:32 PDT

Created attachment 325806 [details] Patch

Alex Christensen

Comment 16 2017-11-02 19:48:34 PDT

Created attachment 325824 [details] Patch

Alex Christensen

Comment 17 2017-11-02 19:54:21 PDT

Created attachment 325825 [details] Patch

Alex Christensen

Comment 18 2017-11-02 19:55:22 PDT

http://trac.webkit.org/r224373

Radar WebKit Bug Importer

Comment 19 2017-11-15 12:27:02 PST

<rdar://problem/35567555>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Alex Christensen

Reported

2017-11-02 00:58 PDT

Modified

2017-11-15 12:27 PST History

CC List

14 users Show

URL

Keywords InRadar

Depends on

Blocks

179265

Dependencies

tree graph