Bug 179142 – Drop running Service Worker Jobs on a background thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Drop running Service Worker Jobs on a background thread. We don't really need to and this simplifies the logic a lot.

[Chris Dumez]

Created attachment 325644 [details]
Patch

[youenn fablet]

Comment on attachment 325644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325644&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:75
> +    ASSERT(isMainThread());

Do we still need these 3 asserts now? For future persistency work maybe, right now they do not add much.

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:198
>      // If jobâs job type is update, and newestWorkerâs script url does not equal jobâs script url with the exclude fragments flag set, then:

s/job's job/job's/

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:257
> +        m_jobTimer.startOneShot(0_s);

Can we have m_jobTimer being active already?
Is startOneShot handling the active state by exiting early?

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:41
> +    , m_scriptURL(scriptURL)

Now that we are no longer doing some background thread things, there might be the possibility to go from IPC up to here without having ref count churn.
Would that be possible here?

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:52
> +    ASSERT(isMainThread());

Probably not needed either.

[Chris Dumez]

Created attachment 325647 [details]
Patch

[Chris Dumez]

Comment on attachment 325647 [details]
Patch

Clearing flags on attachment: 325647

Committed r224306: <https://trac.webkit.org/changeset/224306>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35567992>