Bug 179131 – [Performance] Painting <video> to canvas spends a lot of time in URL getting and parsing

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

[Performance] Painting <video> to canvas spends a lot of time in URL getting and parsing

[Radar WebKit Bug Importer]

<rdar://problem/35297356>

[Jer Noble]

Created attachment 325599 [details]
Patch

[Build Bot]

Attachment 325599 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:208:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Comment on attachment 325599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325599&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:208
> +    void createAVAssetForURL(const URL& url) override;

Nit: "url" isn't necessary.

[Jer Noble]

Created attachment 325630 [details]
Patch for landing

[Jer Noble]

Created attachment 325631 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 325631 [details]
Patch for landing

Clearing flags on attachment: 325631

Committed r224297: <https://trac.webkit.org/changeset/224297>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5727/steps/compile-webkit/logs/stdio

Here is the log after an attempt to fix it in https://trac.webkit.org/changeset/224305/webkit:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5732/steps/compile-webkit/logs/stdio

[Eric Carlson]

(In reply to Ryan Haddad from comment #9)
> This change broke the Windows build:
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 5727/steps/compile-webkit/logs/stdio
> 
> Here is the log after an attempt to fix it in
> https://trac.webkit.org/changeset/224305/webkit:
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 5732/steps/compile-webkit/logs/stdio

Looks like you forgot to update MediaPlayerPrivateAVFoundationCF::createAVAssetForURL for the signature change.

[Ryan Haddad]

The build was fixed with https://trac.webkit.org/changeset/224311/webkit