RESOLVED FIXED 179126
Split JobQueue logic out of SWServerRegistration 
https://bugs.webkit.org/show_bug.cgi?id=179126
Summary Split JobQueue logic out of SWServerRegistration
Chris Dumez
Reported 2017-11-01 10:40:56 PDT
Split JobQueue logic out of SWServerRegistration to match the Service Workers specification more closely.
Attachments
WIP Patch (54.71 KB, patch)
2017-11-01 12:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (47.05 KB, patch)
2017-11-01 12:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (40.04 KB, patch)
2017-11-01 12:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (45.79 KB, patch)
2017-11-01 13:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (48.23 KB, patch)
2017-11-01 13:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (48.99 KB, patch)
2017-11-01 14:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-11-01 11:26:24 PDT
We should probably reuse the registration key and maybe rename it to scope url key since both maps will have the same key
Chris Dumez
Comment 2 2017-11-01 12:05:33 PDT
Will try to keep the patch as small as possible. We can do more refactoring in follow-ups (e.g. getting rid of the background thread).
Chris Dumez
Comment 3 2017-11-01 12:07:55 PDT
Created attachment 325609 [details] WIP Patch
Chris Dumez
Comment 4 2017-11-01 12:09:34 PDT
Created attachment 325610 [details] WIP Patch
Build Bot
Comment 5 2017-11-01 12:12:35 PDT
Attachment 325610 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/server/SWServerJobQueue.h:52: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 6 2017-11-01 12:55:09 PDT
Created attachment 325616 [details] WIP Patch
Chris Dumez
Comment 7 2017-11-01 13:24:34 PDT
Created attachment 325621 [details] WIP Patch
Chris Dumez
Comment 8 2017-11-01 13:38:50 PDT
Created attachment 325624 [details] Patch
Chris Dumez
Comment 9 2017-11-01 14:32:15 PDT
Created attachment 325634 [details] Patch
Chris Dumez
Comment 10 2017-11-01 14:32:38 PDT
Had to rebaseline because of Brady's patch that just landed.
Chris Dumez
Comment 11 2017-11-01 15:32:47 PDT
Comment on attachment 325634 [details] Patch Clearing flags on attachment: 325634 Committed r224301: <https://trac.webkit.org/changeset/224301>
Chris Dumez
Comment 12 2017-11-01 15:32:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2017-11-15 12:30:22 PST
<rdar://problem/35567575>
Note You need to log in before you can comment on or make changes to this bug.