WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
179112
Clear Node renderer pointer when destroying RenderObject
https://bugs.webkit.org/show_bug.cgi?id=179112
Summary
Clear Node renderer pointer when destroying RenderObject
Antti Koivisto
Reported
2017-11-01 04:46:04 PDT
Safer renderer pointer nulling.
Attachments
patch
(62.92 KB, patch)
2017-11-01 04:56 PDT
,
Antti Koivisto
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-elcapitan
(1.62 MB, application/zip)
2017-11-01 05:53 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2
(371.06 KB, application/zip)
2017-11-01 05:54 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
(1.83 MB, application/zip)
2017-11-01 06:00 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews112 for mac-elcapitan
(2.43 MB, application/zip)
2017-11-01 06:13 PDT
,
Build Bot
no flags
Details
patch
(4.08 KB, patch)
2017-11-02 04:25 PDT
,
Antti Koivisto
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-elcapitan
(1.12 MB, application/zip)
2017-11-02 05:24 PDT
,
Build Bot
no flags
Details
patch
(2.01 KB, patch)
2017-11-02 05:38 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Show Obsolete
(7)
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2017-11-01 04:56:04 PDT
Created
attachment 325559
[details]
patch
Build Bot
Comment 2
2017-11-01 05:53:24 PDT
Comment on
attachment 325559
[details]
patch
Attachment 325559
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/5061757
New failing tests: ietestcenter/css3/text/textshadow-004.htm fast/css-generated-content/initial-letter-basic.html fast/css-generated-content/initial-letter-raised.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html accessibility/mac/css-first-letter-children.html fast/css-generated-content/initial-letter-border-padding.html security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html fast/forms/number/number-l10n-input.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html fast/canvas/webgl/viewport-unchanged-upon-resize.html fast/css-generated-content/initial-letter-sunken.html
Build Bot
Comment 3
2017-11-01 05:53:26 PDT
Created
attachment 325565
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 4
2017-11-01 05:54:04 PDT
Comment on
attachment 325559
[details]
patch
Attachment 325559
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/5061744
Number of test failures exceeded the failure limit.
Build Bot
Comment 5
2017-11-01 05:54:05 PDT
Created
attachment 325566
[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Build Bot
Comment 6
2017-11-01 06:00:00 PDT
Comment on
attachment 325559
[details]
patch
Attachment 325559
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/5061784
New failing tests: ietestcenter/css3/text/textshadow-004.htm fast/css-generated-content/initial-letter-basic.html fast/css-generated-content/initial-letter-raised.html accessibility/mac/css-first-letter-children.html fast/css-generated-content/initial-letter-border-padding.html security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html fast/forms/number/number-l10n-input.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html fast/canvas/webgl/viewport-unchanged-upon-resize.html fast/css-generated-content/initial-letter-sunken.html
Build Bot
Comment 7
2017-11-01 06:00:01 PDT
Created
attachment 325567
[details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 8
2017-11-01 06:13:54 PDT
Comment on
attachment 325559
[details]
patch
Attachment 325559
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/5061800
New failing tests: ietestcenter/css3/text/textshadow-004.htm fast/css-generated-content/initial-letter-basic.html fast/css-generated-content/initial-letter-raised.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html accessibility/mac/css-first-letter-children.html fast/css-generated-content/initial-letter-border-padding.html security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html fast/forms/number/number-l10n-input.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html fast/canvas/webgl/viewport-unchanged-upon-resize.html fast/css-generated-content/initial-letter-sunken.html
Build Bot
Comment 9
2017-11-01 06:13:55 PDT
Created
attachment 325568
[details]
Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antti Koivisto
Comment 10
2017-11-02 04:25:52 PDT
Created
attachment 325706
[details]
patch
Build Bot
Comment 11
2017-11-02 05:24:18 PDT
Comment on
attachment 325706
[details]
patch
Attachment 325706
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/5075087
New failing tests: security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html
Build Bot
Comment 12
2017-11-02 05:24:21 PDT
Created
attachment 325709
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antti Koivisto
Comment 13
2017-11-02 05:38:31 PDT
Created
attachment 325712
[details]
patch
alan baradlay
Comment 14
2017-11-02 09:30:24 PDT
Comment on
attachment 325712
[details]
patch At some point we need to reconsider this 2 phase destruction setup.
WebKit Commit Bot
Comment 15
2017-11-02 09:55:29 PDT
Comment on
attachment 325712
[details]
patch Clearing flags on attachment: 325712 Committed
r224336
: <
https://trac.webkit.org/changeset/224336
>
WebKit Commit Bot
Comment 16
2017-11-02 09:55:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 17
2017-11-15 12:29:00 PST
<
rdar://problem/35567624
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug