Bug 179107 – Assert that NoEventDispatchAssertion is not in the stack when executing a script

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Ryosuke Niwa]

We should assert that we're not trying to execute script when NoEventDispatchAssertion is in the stack.

[Ryosuke Niwa]

Created attachment 325554 [details]
Adds assertion

[Ryosuke Niwa]

Once this patch is landed, we can make NoEventDispatchAssertion cheap enough for the main thread to release-assert.

[Radar WebKit Bug Importer]

<rdar://problem/35288788>

[Build Bot]

Attachment 325554 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/ScriptController.cpp:681:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 325554 [details]
Adds assertion

View in context: https://bugs.webkit.org/attachment.cgi?id=325554&action=review

> Source/WebCore/bindings/js/ScriptController.cpp:681
> +        ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::isEventAllowedInMainThread());

Please add a blank line after this.

[Ryosuke Niwa]

(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 325554 [details]
> Adds assertion
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325554&action=review
> 
> > Source/WebCore/bindings/js/ScriptController.cpp:681
> > +        ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::isEventAllowedInMainThread());
> 
> Please add a blank line after this.

Done that.

[Ryosuke Niwa]

Talked with Keith (Miller) and Saam to confirm that creating event listener wouldn't run arbitrary scripts to be sure.

[Ryosuke Niwa]

Committed r224290: <https://trac.webkit.org/changeset/224290>