Bug 179096 - transferFromImageBitmap should update canvas dimensions
Summary: transferFromImageBitmap should update canvas dimensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-31 17:55 PDT by Dean Jackson
Modified: 2017-11-01 11:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.18 KB, patch)
2017-10-31 17:59 PDT, Dean Jackson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-10-31 17:55:19 PDT 
When transferFromImageBitmap is called, the dimensions of the HTMLCanvasElement should be updated.
Comment 1 Radar WebKit Bug Importer 2017-10-31 17:55:54 PDT 
<rdar://problem/35285218>
Comment 2 Dean Jackson 2017-10-31 17:59:25 PDT 
Created attachment 325530 [details]
Patch
Comment 3 Sam Weinig 2017-10-31 19:06:02 PDT 
Comment on attachment 325530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325530&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:982
>          m_imageBuffer = WTFMove(buffer);
>      }
>  
> +    if (m_imageBuffer && m_size != m_imageBuffer->internalSize())
> +        m_size = m_imageBuffer->internalSize();

Why is this function const?
Comment 4 Dean Jackson 2017-11-01 11:44:30 PDT 
Committed r224283: <https://trac.webkit.org/changeset/224283>