Bug 179088 - Fix a couple of service worker tests and unskip them
Summary: Fix a couple of service worker tests and unskip them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/w3c/web-platform-t...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-31 16:28 PDT by Chris Dumez
Modified: 2017-11-15 12:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.93 KB, patch)
2017-10-31 16:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-31 16:28:55 PDT 
Fix a couple of service worker tests and unskip them.

See https://github.com/w3c/web-platform-tests/pull/8019#issuecomment-340915312
Comment 1 Chris Dumez 2017-10-31 16:30:04 PDT 
Created attachment 325521 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-10-31 18:26:44 PDT 
Comment on attachment 325521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325521&action=review

> LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2
> +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller"

These don't seem fixed?
Comment 3 Chris Dumez 2017-10-31 20:08:04 PDT 
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 325521 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325521&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2
> > +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller"
> 
> These don't seem fixed?

The tests are fixed. We still do not pass them, which is expected since service workers is still being implemented.
Comment 4 WebKit Commit Bot 2017-10-31 20:26:45 PDT 
Comment on attachment 325521 [details]
Patch

Clearing flags on attachment: 325521

Committed r224271: <https://trac.webkit.org/changeset/224271>
Comment 5 WebKit Commit Bot 2017-10-31 20:26:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:29:09 PST 
<rdar://problem/35567627>