Bug 179081 - Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html is flaky.
Summary: Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-31 15:23 PDT by Matt Lewis
Modified: 2017-12-06 16:23 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2017-10-31 16:28 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-10-31 15:23:51 PDT
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html is a flaky failure on Sierra and High Sierra testers as well as iOS release testers according to the Dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Ffetch-header-visibility.https.html

The test started being flaky after multiple service worker tests were un-skipped in:
https://trac.webkit.org/changeset/224218/webkit

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r224240%20(835)/results.html
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/835

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https-actual.txt
@@ -1,6 +1,6 @@
 
 
-FAIL Visibility of defaulted headers during interception assert_unreached: unexpected rejection: withUA FAIL - expected "custom_ua", got "<script src="/common/get-host-info.sub.js"></script>
+FAIL Visibility of defaulted headers during interception assert_unreached: unexpected rejection: noUA FAIL - expected "NO_UA", got "<script src="/common/get-host-info.sub.js"></script>
 <script src="test-helpers.sub.js?pipe=sub"></script>
 <script>
   var host_info = get_host_info();
Comment 1 youenn fablet 2017-10-31 16:28:16 PDT
Created attachment 325520 [details]
Patch
Comment 2 WebKit Commit Bot 2017-10-31 16:29:54 PDT
Comment on attachment 325520 [details]
Patch

Rejecting attachment 325520 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 325520, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/5056501
Comment 3 WebKit Commit Bot 2017-10-31 16:54:46 PDT
Comment on attachment 325520 [details]
Patch

Clearing flags on attachment: 325520

Committed r224262: <https://trac.webkit.org/changeset/224262>
Comment 4 WebKit Commit Bot 2017-10-31 16:54:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2017-10-31 18:28:04 PDT
Re-opening, as this only added a flaky test expectation.
Comment 6 youenn fablet 2017-12-06 10:52:25 PST
It is no longer flaky as presented in this report.
One run failed on iOS but there was a Worker crash.
Comment 7 Radar WebKit Bug Importer 2017-12-06 16:23:41 PST
<rdar://problem/35895891>