Bug 179077 - Expose already-available WKNavigationAction.request.HTTPBody through the API
Summary: Expose already-available WKNavigationAction.request.HTTPBody through the API
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2017-10-31 14:12 PDT by Alex Christensen
Modified: 2022-02-01 02:55 PST (History)
4 users (show)

See Also:

Patch (6.16 KB, patch)
2017-10-31 14:13 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.69 KB, patch)
2020-06-23 10:44 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-31 14:12:14 PDT
Encode ResourceRequests' httpBody contents over IPC
Comment 1 Alex Christensen 2017-10-31 14:13:02 PDT
Created attachment 325491 [details]
Comment 2 Geoffrey Garen 2017-10-31 14:38:38 PDT
Can we post this to a perf try-bot to see its impact on benchmarks?
Comment 3 Geoffrey Garen 2017-10-31 14:48:07 PDT
Here's the patch that removed the HTTP body: <https://trac.webkit.org/changeset/144216/webkit>.
Comment 4 Geoffrey Garen 2017-10-31 14:48:25 PDT
I wonder if ap remembers what the performance test that motivated this was.
Comment 5 Geoffrey Garen 2017-10-31 14:50:41 PDT
I think it might be better for clients to use _WKInputDelegate.
Comment 6 Alexey Proskuryakov 2017-10-31 18:29:07 PDT
This was not about benchmarks, but about extreme cases. E.g. how are we going to upload videos to YouTube now?
Comment 7 Alexey Proskuryakov 2017-10-31 18:30:30 PDT
Oh, and the secondary concern was consistency - one can't encode a stream, so any feature based on seeing the content in another process will be working inconsistently.
Comment 8 Alex Christensen 2017-11-01 14:47:16 PDT
Comment on attachment 325491 [details]

I think this is not a good solution.
Comment 9 David Kilzer (:ddkilzer) 2020-06-22 18:41:58 PDT
Comment 10 Alex Christensen 2020-06-23 10:44:07 PDT
Created attachment 402567 [details]
Comment 11 EWS 2020-06-23 12:00:15 PDT
Committed r263411: <https://trac.webkit.org/changeset/263411>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402567 [details].