This will be more efficient
Created attachment 325487 [details] Patch
Comment on attachment 325487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325487&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:33 > + Nit: extra blank line > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h:8 > + * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. > + * > + * Use of this source code is governed by a BSD-style license > + * that can be found in the LICENSE file in the root of the source > + * tree. An additional intellectual property rights grant can be found > + * in the file PATENTS. All contributing project authors may > + * be found in the AUTHORS file in the root of the source tree. Is this the correct header? > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h:43 > +// This file provides a H264 encoder implementation using the VideoToolbox > +// APIs. Since documentation is almost non-existent, this is largely based on > +// the information in the VideoToolbox header files, a talk from WWDC 2014 and > +// experimentation. This is incorrect.
Created attachment 325773 [details] Patch
Comment on attachment 325773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325773&action=review > Source/ThirdParty/libwebrtc/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=179076 please add reference to radar.
rdar://problem/35180773
Created attachment 325803 [details] Patch
(In reply to youenn fablet from comment #6) > Created attachment 325803 [details] > Patch Fixing macOS version. Need to handle iOS sim/iOS missing private framework.
Created attachment 325908 [details] Patch
Comment on attachment 325908 [details] Patch Patch only activates VCP for MacOS right now. It should be extended to iOS at some point.
Comment on attachment 325908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325908&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h:3 > + * Copyright (c) 2017 Apple INC. All Rights Reserved. Nit: Apple INC => Apple Inc > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.mm:3 > + * Copyright (c) 2017 Apple INC. All Rights Reserved. Ditto.
Created attachment 325956 [details] Patch for landing
Thanks for the review. Patch updated accordingly.
Comment on attachment 325956 [details] Patch for landing Clearing flags on attachment: 325956 Committed r224428: <https://trac.webkit.org/changeset/224428>
All reviewed patches have been landed. Closing bug.
Reopening to attach new patch.
Created attachment 325966 [details] Build fix
Comment on attachment 325966 [details] Build fix Clearing flags on attachment: 325966 Committed r224435: <https://trac.webkit.org/changeset/224435>
Created attachment 325974 [details] Build fix
Created attachment 325977 [details] Build fix
Comment on attachment 325977 [details] Build fix Clearing flags on attachment: 325977 Committed r224440: <https://trac.webkit.org/changeset/224440>
Re-opened since this is blocked by bug 179274
Created attachment 325992 [details] Trying to fix build again
Comment on attachment 325992 [details] Trying to fix build again Clearing flags on attachment: 325992 Committed r224497: <https://trac.webkit.org/changeset/224497>
Re-opened since this is blocked by bug 179335
Created attachment 329025 [details] Patch
Created attachment 329032 [details] Patch
Created attachment 329040 [details] Patch
Comment on attachment 329040 [details] Patch Clearing flags on attachment: 329040 Committed r225761: <https://trac.webkit.org/changeset/225761>
This caused an API failure with test ContentFiltering.LazilyLoadPlatformFrameworks https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1689 https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1689/steps/run-api-tests/logs/stdio Failure: FAIL ContentFiltering.LazilyLoadPlatformFrameworks /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366 Value of: static_cast<bool>(networkExtensionLoaded) Actual: true Expected: static_cast<bool>(networkExtensionShouldBeLoaded) Which is: false /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366 Value of: static_cast<bool>(networkExtensionLoaded) Actual: true Expected: static_cast<bool>(networkExtensionShouldBeLoaded) Which is: false /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366 Value of: static_cast<bool>(networkExtensionLoaded) Actual: true Expected: static_cast<bool>(networkExtensionShouldBeLoaded) Which is: false /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366 Value of: static_cast<bool>(networkExtensionLoaded) Actual: true Expected: static_cast<bool>(networkExtensionShouldBeLoaded) Which is: false /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366 Value of: static_cast<bool>(networkExtensionLoaded) Actual: true Expected: static_cast<bool>(networkExtensionShouldBeLoaded) Which is: false