Bug 179076 – Use VCP H264 encoder for platforms supporting it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

This will be more efficient

[youenn fablet]

Created attachment 325487 [details]
Patch

[Eric Carlson]

Comment on attachment 325487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325487&action=review

> Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:33
> +

Nit: extra blank line

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h:8
> + *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
> + *
> + *  Use of this source code is governed by a BSD-style license
> + *  that can be found in the LICENSE file in the root of the source
> + *  tree. An additional intellectual property rights grant can be found
> + *  in the file PATENTS.  All contributing project authors may
> + *  be found in the AUTHORS file in the root of the source tree.

Is this the correct header?

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h:43
> +// This file provides a H264 encoder implementation using the VideoToolbox
> +// APIs. Since documentation is almost non-existent, this is largely based on
> +// the information in the VideoToolbox header files, a talk from WWDC 2014 and
> +// experimentation.

This is incorrect.

[youenn fablet]

Created attachment 325773 [details]
Patch

[Jon Lee]

Comment on attachment 325773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325773&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=179076

please add reference to radar.

[Jon Lee]

rdar://problem/35180773

[youenn fablet]

Created attachment 325803 [details]
Patch

[youenn fablet]

(In reply to youenn fablet from comment #6)
> Created attachment 325803 [details]
> Patch

Fixing macOS version.
Need to handle iOS sim/iOS missing private framework.

[youenn fablet]

Created attachment 325908 [details]
Patch

[youenn fablet]

Comment on attachment 325908 [details]
Patch

Patch only activates VCP for MacOS right now.
It should be extended to iOS at some point.

[Eric Carlson]

Comment on attachment 325908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325908&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h:3
> + *  Copyright (c) 2017 Apple INC. All Rights Reserved.

Nit: Apple INC => Apple Inc

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.mm:3
> + *  Copyright (c) 2017 Apple INC. All Rights Reserved.

Ditto.

[youenn fablet]

Created attachment 325956 [details]
Patch for landing

[youenn fablet]

Thanks for the review.
Patch updated accordingly.

[WebKit Commit Bot]

Comment on attachment 325956 [details]
Patch for landing

Clearing flags on attachment: 325956

Committed r224428: <https://trac.webkit.org/changeset/224428>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 325966 [details]
Build fix

[WebKit Commit Bot]

Comment on attachment 325966 [details]
Build fix

Clearing flags on attachment: 325966

Committed r224435: <https://trac.webkit.org/changeset/224435>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 325974 [details]
Build fix

[youenn fablet]

Created attachment 325977 [details]
Build fix

[WebKit Commit Bot]

Comment on attachment 325977 [details]
Build fix

Clearing flags on attachment: 325977

Committed r224440: <https://trac.webkit.org/changeset/224440>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 179274

[youenn fablet]

Created attachment 325992 [details]
Trying to fix build again

[WebKit Commit Bot]

Comment on attachment 325992 [details]
Trying to fix build again

Clearing flags on attachment: 325992

Committed r224497: <https://trac.webkit.org/changeset/224497>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 179335

[youenn fablet]

Created attachment 329025 [details]
Patch

[youenn fablet]

Created attachment 329032 [details]
Patch

[youenn fablet]

Created attachment 329040 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 329040 [details]
Patch

Clearing flags on attachment: 329040

Committed r225761: <https://trac.webkit.org/changeset/225761>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This caused an API failure with test ContentFiltering.LazilyLoadPlatformFrameworks

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1689
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1689/steps/run-api-tests/logs/stdio

Failure:


FAIL ContentFiltering.LazilyLoadPlatformFrameworks

/Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366
Value of: static_cast<bool>(networkExtensionLoaded)
  Actual: true
Expected: static_cast<bool>(networkExtensionShouldBeLoaded)
Which is: false


/Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366
Value of: static_cast<bool>(networkExtensionLoaded)
  Actual: true
Expected: static_cast<bool>(networkExtensionShouldBeLoaded)
Which is: false


/Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366
Value of: static_cast<bool>(networkExtensionLoaded)
  Actual: true
Expected: static_cast<bool>(networkExtensionShouldBeLoaded)
Which is: false


/Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366
Value of: static_cast<bool>(networkExtensionLoaded)
  Actual: true
Expected: static_cast<bool>(networkExtensionShouldBeLoaded)
Which is: false


/Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:366
Value of: static_cast<bool>(networkExtensionLoaded)
  Actual: true
Expected: static_cast<bool>(networkExtensionShouldBeLoaded)
Which is: false