Bug 179071 - StructureStubInfo should have GPRReg members not int8_ts
Summary: StructureStubInfo should have GPRReg members not int8_ts
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on: 179083
Blocks:
  Show dependency tree / graph
 
Reported: 2017-10-31 12:54 PDT by Keith Miller
Modified: 2017-10-31 16:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (16.24 KB, patch)
2017-10-31 12:56 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (16.24 KB, patch)
2017-10-31 12:58 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-10-31 12:54:19 PDT 
StructureStubInfo should have an GPRReg members not int8_ts
Comment 1 Keith Miller 2017-10-31 12:56:42 PDT 
Created attachment 325475 [details]
Patch
Comment 2 Michael Saboff 2017-10-31 12:58:10 PDT 
Comment on attachment 325475 [details]
Patch

r=me
Comment 3 Keith Miller 2017-10-31 12:58:55 PDT 
Created attachment 325476 [details]
Patch for landing
Comment 4 Mark Lam 2017-10-31 13:00:17 PDT 
Comment on attachment 325475 [details]
Patch

r=me.  Please also make FPRegister and SPRegister extend uint8_t for consistency.  I don't mind if you do it in a separate patch.
Comment 5 WebKit Commit Bot 2017-10-31 13:29:59 PDT 
Comment on attachment 325476 [details]
Patch for landing

Clearing flags on attachment: 325476

Committed r224243: <https://trac.webkit.org/changeset/224243>
Comment 6 WebKit Commit Bot 2017-10-31 13:30:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2017-10-31 16:10:21 PDT 
Re-opened since this is blocked by bug 179083