WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
179071
StructureStubInfo should have GPRReg members not int8_ts
https://bugs.webkit.org/show_bug.cgi?id=179071
Summary
StructureStubInfo should have GPRReg members not int8_ts
Keith Miller
Reported
2017-10-31 12:54:19 PDT
StructureStubInfo should have an GPRReg members not int8_ts
Attachments
Patch
(16.24 KB, patch)
2017-10-31 12:56 PDT
,
Keith Miller
no flags
Details
Formatted Diff
Diff
Patch for landing
(16.24 KB, patch)
2017-10-31 12:58 PDT
,
Keith Miller
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Keith Miller
Comment 1
2017-10-31 12:56:42 PDT
Created
attachment 325475
[details]
Patch
Michael Saboff
Comment 2
2017-10-31 12:58:10 PDT
Comment on
attachment 325475
[details]
Patch r=me
Keith Miller
Comment 3
2017-10-31 12:58:55 PDT
Created
attachment 325476
[details]
Patch for landing
Mark Lam
Comment 4
2017-10-31 13:00:17 PDT
Comment on
attachment 325475
[details]
Patch r=me. Please also make FPRegister and SPRegister extend uint8_t for consistency. I don't mind if you do it in a separate patch.
WebKit Commit Bot
Comment 5
2017-10-31 13:29:59 PDT
Comment on
attachment 325476
[details]
Patch for landing Clearing flags on attachment: 325476 Committed
r224243
: <
https://trac.webkit.org/changeset/224243
>
WebKit Commit Bot
Comment 6
2017-10-31 13:30:00 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 7
2017-10-31 16:00:08 PDT
This patch caused a build failure on windows:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5699/steps/compile-webkit/logs/stdio
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5699/steps/compile-webkit/logs/stdio
WebKit Commit Bot
Comment 8
2017-10-31 16:10:21 PDT
Re-opened since this is blocked by
bug 179083
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug