Bug 179066 - [Web Animations] Support AnimationEffect parameter in Animation constructor and read-write timeline property
Summary: [Web Animations] Support AnimationEffect parameter in Animation constructor a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-31 12:15 PDT by Antoine Quint
Modified: 2017-11-01 05:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (33.69 KB, patch)
2017-10-31 12:18 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-10-31 12:15:01 PDT
[Web Animations] Support AnimationEffect parameter in Animation constructor and read-write timeline property
Comment 1 Antoine Quint 2017-10-31 12:18:04 PDT
Created attachment 325467 [details]
Patch
Comment 2 Dean Jackson 2017-10-31 12:46:22 PDT
Comment on attachment 325467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325467&action=review

> Source/WebCore/animation/WebAnimation.cpp:67
> +void WebAnimation::setTimeline(RefPtr<AnimationTimeline>&& timeline)

I'm not sure you need && here. Why do you use it?

The calling location is always casting a raw pointer to a RefPtr.  I guess the implicitly created RefPtr can be moved, but I'm not sure it makes much difference. I'm clearly not a C++ expert.
Comment 3 WebKit Commit Bot 2017-10-31 13:28:22 PDT
Comment on attachment 325467 [details]
Patch

Clearing flags on attachment: 325467

Committed r224242: <https://trac.webkit.org/changeset/224242>
Comment 4 WebKit Commit Bot 2017-10-31 13:28:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-01 05:52:59 PDT
<rdar://problem/35291587>