RESOLVED FIXED 179066
[Web Animations] Support AnimationEffect parameter in Animation constructor and read-write timeline property 
https://bugs.webkit.org/show_bug.cgi?id=179066
Summary [Web Animations] Support AnimationEffect parameter in Animation constructor a...
Antoine Quint
Reported 2017-10-31 12:15:01 PDT
[Web Animations] Support AnimationEffect parameter in Animation constructor and read-write timeline property
Attachments
Patch (33.69 KB, patch)
2017-10-31 12:18 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-10-31 12:18:04 PDT
Created attachment 325467 [details] Patch
Dean Jackson
Comment 2 2017-10-31 12:46:22 PDT
Comment on attachment 325467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325467&action=review > Source/WebCore/animation/WebAnimation.cpp:67 > +void WebAnimation::setTimeline(RefPtr<AnimationTimeline>&& timeline) I'm not sure you need && here. Why do you use it? The calling location is always casting a raw pointer to a RefPtr. I guess the implicitly created RefPtr can be moved, but I'm not sure it makes much difference. I'm clearly not a C++ expert.
WebKit Commit Bot
Comment 3 2017-10-31 13:28:22 PDT
Comment on attachment 325467 [details] Patch Clearing flags on attachment: 325467 Committed r224242: <https://trac.webkit.org/changeset/224242>
WebKit Commit Bot
Comment 4 2017-10-31 13:28:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-01 05:52:59 PDT
<rdar://problem/35291587>
Note You need to log in before you can comment on or make changes to this bug.