Bug 179056 - [Payment Request] show() should only be called with user activation
Summary: [Payment Request] show() should only be called with user activation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks: 174796
  Show dependency treegraph
 
Reported: 2017-10-31 07:56 PDT by Andy Estes
Modified: 2017-11-15 12:31 PST (History)
10 users (show)

See Also:


Attachments
Patch (86.83 KB, patch)
2017-10-31 07:57 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (8.25 MB, application/zip)
2017-10-31 09:25 PDT, Build Bot
no flags Details
Patch (38.99 KB, patch)
2017-11-02 22:46 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-10-31 07:56:01 PDT
[Payment Request] show() should only be called with user activation
Comment 1 Andy Estes 2017-10-31 07:57:09 PDT
Created attachment 325439 [details]
Patch
Comment 2 Build Bot 2017-10-31 09:25:16 PDT
Comment on attachment 325439 [details]
Patch

Attachment 325439 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5051087

New failing tests:
http/tests/paymentrequest/payment-request-show-method.https.html
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
Comment 3 Build Bot 2017-10-31 09:25:17 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2017-10-31 09:45:33 PDT
Comment on attachment 325439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325439&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:385
> +    if (!ScriptController::processingUserGesture()) {

Can this use UserGestureIndicator::processingUserGesture() instead?  I'm not sure why we have the ScriptController wrapper.
Comment 5 Andy Estes 2017-10-31 15:36:39 PDT
(In reply to Sam Weinig from comment #4)
> Comment on attachment 325439 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325439&action=review
> 
> > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:385
> > +    if (!ScriptController::processingUserGesture()) {
> 
> Can this use UserGestureIndicator::processingUserGesture() instead?  I'm not
> sure why we have the ScriptController wrapper.

I don't know either! Yes, I'll just use UserGestureIndicator directly.

Thanks for reviewing!
Comment 6 Andy Estes 2017-11-02 22:46:00 PDT
Created attachment 325857 [details]
Patch
Comment 7 WebKit Commit Bot 2017-11-03 09:15:23 PDT
Comment on attachment 325857 [details]
Patch

Rejecting attachment 325857 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 325857, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.webkit.org/git/WebKit
   8b2f187..acc0875  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 224398 = 8b2f1874e0727bb207e8e4625870763b3d75dc5e
r224399 = acc087508a211872dd03a0bfa55e983e9d361854
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/5091161
Comment 8 Andy Estes 2017-11-03 09:36:04 PDT
Committed r224402: <https://trac.webkit.org/changeset/224402>
Comment 9 Radar WebKit Bug Importer 2017-11-15 12:31:40 PST
<rdar://problem/35567687>