Bug 179056 – [Payment Request] show() should only be called with user activation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Payment Request] show() should only be called with user activation

[Andy Estes]

Created attachment 325439 [details]
Patch

[Build Bot]

Comment on attachment 325439 [details]
Patch

Attachment 325439 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5051087

New failing tests:
http/tests/paymentrequest/payment-request-show-method.https.html
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html

[Build Bot]

Created attachment 325448 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Sam Weinig]

Comment on attachment 325439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325439&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:385
> +    if (!ScriptController::processingUserGesture()) {

Can this use UserGestureIndicator::processingUserGesture() instead?  I'm not sure why we have the ScriptController wrapper.

[Andy Estes]

(In reply to Sam Weinig from comment #4)
> Comment on attachment 325439 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325439&action=review
> 
> > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:385
> > +    if (!ScriptController::processingUserGesture()) {
> 
> Can this use UserGestureIndicator::processingUserGesture() instead?  I'm not
> sure why we have the ScriptController wrapper.

I don't know either! Yes, I'll just use UserGestureIndicator directly.

Thanks for reviewing!

[Andy Estes]

Created attachment 325857 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 325857 [details]
Patch

Rejecting attachment 325857 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 325857, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.webkit.org/git/WebKit
   8b2f187..acc0875  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 224398 = 8b2f1874e0727bb207e8e4625870763b3d75dc5e
r224399 = acc087508a211872dd03a0bfa55e983e9d361854
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/5091161

[Andy Estes]

Committed r224402: <https://trac.webkit.org/changeset/224402>

[Radar WebKit Bug Importer]

<rdar://problem/35567687>