Bug 179048 - Web Inspector: make ScriptCallStack::maxCallStackSizeToCapture the default value when capturing backtraces
Summary: Web Inspector: make ScriptCallStack::maxCallStackSizeToCapture the default va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-31 00:44 PDT by Devin Rousso
Modified: 2017-11-15 12:35 PST (History)
18 users (show)

See Also:

Attachments
Patch (15.71 KB, patch)
2017-10-31 01:55 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-10-31 00:44:16 PDT 
To quote JoePeck:

> We should really make ScriptCallStack::maxCallStackSizeToCapture a default value. Its ridiculous that pretty much every caller passes it.

:)
Comment 1 Devin Rousso 2017-10-31 01:55:37 PDT 
Created attachment 325428 [details]
Patch
Comment 2 Mark Lam 2017-10-31 08:52:23 PDT 
Comment on attachment 325428 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2017-10-31 11:04:13 PDT 
Comment on attachment 325428 [details]
Patch

Nice! This is a rare case where I feel default parameter values is justified!
Comment 4 WebKit Commit Bot 2017-10-31 11:34:28 PDT 
Comment on attachment 325428 [details]
Patch

Clearing flags on attachment: 325428

Committed r224236: <https://trac.webkit.org/changeset/224236>
Comment 5 WebKit Commit Bot 2017-10-31 11:34:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:35:18 PST 
<rdar://problem/35567698>