RESOLVED FIXED 179048
Web Inspector: make ScriptCallStack::maxCallStackSizeToCapture the default value when capturing backtraces
https://bugs.webkit.org/show_bug.cgi?id=179048
Summary Web Inspector: make ScriptCallStack::maxCallStackSizeToCapture the default va...
Devin Rousso
Reported 2017-10-31 00:44:16 PDT
To quote JoePeck: > We should really make ScriptCallStack::maxCallStackSizeToCapture a default value. Its ridiculous that pretty much every caller passes it. :)
Attachments
Patch (15.71 KB, patch)
2017-10-31 01:55 PDT, Devin Rousso
no flags
Devin Rousso
Comment 1 2017-10-31 01:55:37 PDT
Mark Lam
Comment 2 2017-10-31 08:52:23 PDT
Comment on attachment 325428 [details] Patch r=me
Joseph Pecoraro
Comment 3 2017-10-31 11:04:13 PDT
Comment on attachment 325428 [details] Patch Nice! This is a rare case where I feel default parameter values is justified!
WebKit Commit Bot
Comment 4 2017-10-31 11:34:28 PDT
Comment on attachment 325428 [details] Patch Clearing flags on attachment: 325428 Committed r224236: <https://trac.webkit.org/changeset/224236>
WebKit Commit Bot
Comment 5 2017-10-31 11:34:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 12:35:18 PST
Note You need to log in before you can comment on or make changes to this bug.