Bug 179014 – Remove empty continuations in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

Treat continuation similarly to other anonymous wrappers. This makes things more understandable and allows removal of some questionable code in RenderBlock::takeChild.

[Antti Koivisto]

Created attachment 325433 [details]
patch

[Build Bot]

Comment on attachment 325433 [details]
patch

Attachment 325433 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5050236

New failing tests:
fast/ruby/rubyDOM-remove-rt1.html
fast/ruby/float-overhang-from-ruby-text.html

[Build Bot]

Created attachment 325434 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 325433 [details]
patch

Attachment 325433 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5050256

New failing tests:
fast/ruby/rubyDOM-remove-rt1.html
fast/ruby/float-overhang-from-ruby-text.html

[Build Bot]

Created attachment 325435 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 325433 [details]
patch

Attachment 325433 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5050252

New failing tests:
fast/ruby/rubyDOM-remove-rt1.html
fast/ruby/float-overhang-from-ruby-text.html

[Build Bot]

Created attachment 325436 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 325437 [details]
patch

[Antti Koivisto]

Created attachment 325449 [details]
patch

[Antti Koivisto]

Created attachment 325456 [details]
patch

[Geoffrey Garen]

Comment on attachment 325456 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325456&action=review

r=me

> Source/WebCore/rendering/RenderBoxModelObject.cpp:81
> +struct RenderBoxModelObject::ContinuationChainNode {

You should use MAKE_FAST_ALLOCATED here.

[Antti Koivisto]

Created attachment 325466 [details]
patch

[WebKit Commit Bot]

Comment on attachment 325466 [details]
patch

Clearing flags on attachment: 325466

Committed r224273: <https://trac.webkit.org/changeset/224273>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 179120

[Antti Koivisto]

Guard malloc crashes were due to code in RenderRubyRun::takeChild where it destroys itself (similar to RenderBlock one).

[Antti Koivisto]

Created attachment 325701 [details]
patch

[WebKit Commit Bot]

Comment on attachment 325701 [details]
patch

Clearing flags on attachment: 325701

Committed r224327: <https://trac.webkit.org/changeset/224327>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

30 LayoutTests are hitting an assertion failure after re-landing this change:

ASSERTION FAILED: !continuationChainNode.next->renderer->firstChild()
/Volumes/Data/slave/sierra-debug/build/Source/WebCore/rendering/RenderBoxModelObject.cpp(2539) : void WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations()
1   0x123078b5d WTFCrash
2   0x11831dd02 WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations()
3   0x1182f4490 WebCore::RenderBoxModelObject::willBeDestroyed()
4   0x1183b6048 WebCore::RenderInline::willBeDestroyed()
5   0x11846ba3e WebCore::RenderObject::destroy()
6   0x11846b8f9 WebCore::RenderObjectDeleter::operator()(WebCore::RenderObject*) const
7   0x118341c07 WebCore::RenderElement::removeAndDestroyChild(WebCore::RenderObject&)
8   0x11846497c WebCore::RenderObject::removeFromParentAndDestroy()
9   0x11847111f WebCore::RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers()
10  0x118673ceb WebCore::RenderTreeUpdater::tearDownRenderers(WebCore::Element&, WebCore::RenderTreeUpdater::TeardownType)::$_8::operator()(unsigned int) const
11  0x118671393 WebCore::RenderTreeUpdater::tearDownRenderers(WebCore::Element&, WebCore::RenderTreeUpdater::TeardownType)
12  0x118673bc7 WebCore::RenderTreeUpdater::tearDownRenderers(WebCore::Element&)
13  0x11747f7ec WebCore::Document::destroyRenderTree()
14  0x11747fb7a WebCore::Document::prepareForDestruction()
15  0x117c9e180 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView>&&)
16  0x117ca0753 WebCore::Frame::createView(WebCore::IntSize const&, WebCore::Color const&, bool, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool)
17  0x10d2af772 WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage()
18  0x117b263d6 WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*)
19  0x117b2546a WebCore::FrameLoader::commitProvisionalLoad()
20  0x117adad2c WebCore::DocumentLoader::commitIfReady()
21  0x117adb052 WebCore::DocumentLoader::finishedLoading()
22  0x117ae2ba5 WebCore::DocumentLoader::maybeLoadEmpty()
23  0x117ae2d2d WebCore::DocumentLoader::startLoadingMainResource()
24  0x117b40814 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)::$_8::operator()() const
25  0x117b40559 WTF::Function<void ()>::CallableWrapper<WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)::$_8>::call()
26  0x11585effb WTF::Function<void ()>::operator()() const
27  0x117b237cd WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)
28  0x117b3f148 WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WebCore::FormState*, WebCore::AllowNavigationToInvalidURL)::$_6::operator()(WebCore::ResourceRequest const&, WebCore::FormState*, bool) const
29  0x117b3f0d2 WTF::Function<void (WebCore::ResourceRequest const&, WebCore::FormState*, bool)>::CallableWrapper<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WebCore::FormState*, WebCore::AllowNavigationToInvalidURL)::$_6>::call(WebCore::ResourceRequest const&, WebCore::FormState*, bool)
30  0x117b6b92d WTF::Function<void (WebCore::ResourceRequest const&, WebCore::FormState*, bool)>::operator()(WebCore::ResourceRequest const&, WebCore::FormState*, bool) const
31  0x117b621b9 WTF::CompletionHandler<void (WebCore::ResourceRequest const&, WebCore::FormState*, bool)>::operator()(WebCore::ResourceRequest const&, WebCore::FormState*, bool)
LEAK: 1 WebPageProxy

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r224329%20(3837)/results.html

[Antti Koivisto]

Removed the assertion in https://trac.webkit.org/r224332

[Radar WebKit Bug Importer]

<rdar://problem/35567802>