Bug 178976 – self.ExtendableEvent / Client / Clients / WindowClient do not exist in a Service Worker

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

self.ExtendableEvent / Client / Clients / WindowClient do not exist in a Service Worker.

[Chris Dumez]

Created attachment 325239 [details]
Patch

[Build Bot]

Comment on attachment 325239 [details]
Patch

Attachment 325239 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5020644

New failing tests:
http/tests/workers/service/ServiceWorkerGlobalScope-properties.html

[Build Bot]

Created attachment 325251 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Sam Weinig]

Comment on attachment 325239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325239&action=review

> LayoutTests/http/tests/workers/service/resources/ServiceWorkerGlobalScope-properties-worker.js:9
> +self.addEventListener("message", (event) => {
> +    if (event.data === "LIST") {
> +        let properties = Object.getOwnPropertyNames(self);
> +        properties.sort()
> +        for (let p of properties)
> +            event.source.postMessage(p);
> +        event.source.postMessage("DONE");
> +    }
> +});

I'm not a big fan of this type of test, as it tends to be hard to keep one set of expected results as some platforms enable some features (I recently removed a similar set of tests for windows).  Can we have a more targeted test, rather than one that iterates all of the global object?

[Sam Weinig]

Comment on attachment 325239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325239&action=review

>> LayoutTests/http/tests/workers/service/resources/ServiceWorkerGlobalScope-properties-worker.js:9
>> +self.addEventListener("message", (event) => {
>> +    if (event.data === "LIST") {
>> +        let properties = Object.getOwnPropertyNames(self);
>> +        properties.sort()
>> +        for (let p of properties)
>> +            event.source.postMessage(p);
>> +        event.source.postMessage("DONE");
>> +    }
>> +});
> 
> I'm not a big fan of this type of test, as it tends to be hard to keep one set of expected results as some platforms enable some features (I recently removed a similar set of tests for windows).  Can we have a more targeted test, rather than one that iterates all of the global object?

I'm not a big fan of this type of test, as it tends to be hard to keep one set of expected results as some platforms enable some features (I recently removed a similar set of tests for windows).  Can we have a more targeted test, rather than one that iterates all of the global object?

[Chris Dumez]

(In reply to Sam Weinig from comment #5)
> Comment on attachment 325239 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325239&action=review
> 
> >> LayoutTests/http/tests/workers/service/resources/ServiceWorkerGlobalScope-properties-worker.js:9
> >> +self.addEventListener("message", (event) => {
> >> +    if (event.data === "LIST") {
> >> +        let properties = Object.getOwnPropertyNames(self);
> >> +        properties.sort()
> >> +        for (let p of properties)
> >> +            event.source.postMessage(p);
> >> +        event.source.postMessage("DONE");
> >> +    }
> >> +});
> > 
> > I'm not a big fan of this type of test, as it tends to be hard to keep one set of expected results as some platforms enable some features (I recently removed a similar set of tests for windows).  Can we have a more targeted test, rather than one that iterates all of the global object?
> 
> I'm not a big fan of this type of test, as it tends to be hard to keep one
> set of expected results as some platforms enable some features (I recently
> removed a similar set of tests for windows).  Can we have a more targeted
> test, rather than one that iterates all of the global object?

Sure, I can make one that is more targeted.

[Chris Dumez]

Created attachment 325263 [details]
Patch

[Chris Dumez]

Comment on attachment 325263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325263&action=review

> LayoutTests/http/tests/workers/service/ServiceWorkerGlobalScope-properties-expected.txt:8
> +Object.getOwnPropertyDescriptor(self, 'ExtendableMessageEvent') returned {"writable":true,"enumerable":false,"configurable":true}

More targeted testing.

[WebKit Commit Bot]

Comment on attachment 325263 [details]
Patch

Clearing flags on attachment: 325263

Committed r224153: <https://trac.webkit.org/changeset/224153>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35567819>