Bug 178975 - Extract a WorkerDebuggerProxy interface out of WorkerReportingProxy
Summary: Extract a WorkerDebuggerProxy interface out of WorkerReportingProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-27 20:47 PDT by Joseph Pecoraro
Modified: 2017-11-15 12:35 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (26.97 KB, patch)
2017-10-27 21:10 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-10-27 20:47:34 PDT 
Extract WorkerDebuggerProxy interface out of WorkerReportingProxy.

This method:

    void postMessageToPageInspector(const String&)

Is not like the others in ReportingProxy, its more like the Loader methods and can stand on its own.

I'm going to extra it, with an intent to implement it soon after in ServiceWorkerThreadProxy.
Comment 1 Joseph Pecoraro 2017-10-27 21:10:07 PDT 
Created attachment 325238 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2017-10-27 21:13:18 PDT 
Attachment 325238 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/WorkerMessagingProxy.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-10-28 07:35:52 PDT 
Comment on attachment 325238 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 325238

Committed r224147: <https://trac.webkit.org/changeset/224147>
Comment 4 WebKit Commit Bot 2017-10-28 07:35:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:35:15 PST 
<rdar://problem/35567821>