Bug 178969 - Correctly determine affinity when inserting text via Keyboard Suggestions
Summary: Correctly determine affinity when inserting text via Keyboard Suggestions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-27 19:14 PDT by Megan Gardner
Modified: 2017-10-30 14:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2017-10-27 19:20 PDT, Megan Gardner
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-10-27 19:14:58 PDT
Correctly determine affinity when inserting text via Keyboard Suggestions
Comment 1 Megan Gardner 2017-10-27 19:20:06 PDT
Created attachment 325231 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-10-27 19:21:11 PDT
<rdar://problem/35233885>
Comment 3 Ryosuke Niwa 2017-10-30 12:11:11 PDT
Comment on attachment 325231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325231&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1865
> +    // correctly determine affinity, using logic currently only present in VisiblePosition

Nit: Capitalize "correctly".
Comment 4 Megan Gardner 2017-10-30 14:25:18 PDT
https://trac.webkit.org/r224201