Bug 178967 - Make WKWebViewConfiguration a wrapper around API::PageConfiguration
Summary: Make WKWebViewConfiguration a wrapper around API::PageConfiguration
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 16:55 PDT by Alex Christensen
Modified: 2018-01-03 12:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (70.75 KB, patch)
2017-10-27 16:56 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (85.06 KB, patch)
2017-12-19 20:35 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (559.91 KB, application/zip)
2017-12-19 21:10 PST, EWS Watchlist 		no flags Details
Patch (88.28 KB, patch)
2018-01-02 14:53 PST, Alex Christensen 		achristensen: review-
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-27 16:55:29 PDT 
Make WKWebViewConfiguration a wrapper around API::PageConfiguration
Comment 1 Alex Christensen 2017-10-27 16:56:42 PDT 
Created attachment 325220 [details]
Patch
Comment 2 Alex Christensen 2017-10-27 16:57:37 PDT 
Comment on attachment 325220 [details]
Patch

There are a few things wrong with this patch, but it's good WIP.
Among the problems are: this assertion is firing and I'm not sure why:
    ASSERT([pageConfiguration.wrapper() isKindOfClass:[WKWebViewConfiguration class]]);
Comment 3 Alex Christensen 2017-12-19 20:35:35 PST 
Created attachment 329889 [details]
Patch
Comment 4 EWS Watchlist 2017-12-19 21:10:16 PST 
Comment on attachment 329889 [details]
Patch

Attachment 329889 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5766649

Number of test failures exceeded the failure limit.
Comment 5 EWS Watchlist 2017-12-19 21:10:17 PST 
Created attachment 329894 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Alex Christensen 2018-01-02 14:53:52 PST 
Created attachment 330340 [details]
Patch
Comment 7 EWS Watchlist 2018-01-02 16:32:13 PST 
Comment on attachment 330340 [details]
Patch

Attachment 330340 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5896921

Number of test failures exceeded the failure limit.