Bug 178949 – Bytecode liveness should live on UnlinkedCodeBlock so it can be shared amongst CodeBlocks

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 325201 [details]
WIP

refactoring

[Saam Barati]

Created attachment 325204 [details]
WIP

[Saam Barati]

(In reply to Saam Barati from comment #2)
> Created attachment 325204 [details]
> WIP

It seems to work.

[Build Bot]

Attachment 325204 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:89:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:91:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:92:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:93:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:95:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:117:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Created attachment 325212 [details]
patch

[Saam Barati]

Created attachment 325213 [details]
patch

[Saam Barati]

Comment on attachment 325213 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325213&action=review

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:430
> +    {
> +        auto locker = holdLock(m_lock);
> +        m_liveness = std::make_unique<BytecodeLivenessAnalysis>(codeBlock);
> +    }

Keith pointed out I need to check if we have m_liveness already or not to avoid computing it twice.

[Saam Barati]

Created attachment 325214 [details]
patch

[Saam Barati]

Created attachment 325219 [details]
patch

[Keith Miller]

Comment on attachment 325219 [details]
patch

r=me if you get GCC working.

[WebKit Commit Bot]

Comment on attachment 325219 [details]
patch

Clearing flags on attachment: 325219

Committed r224138: <https://trac.webkit.org/changeset/224138>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35567840>