Bug 178944 - Unskip more Service Workers tests
Summary: Unskip more Service Workers tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-27 10:29 PDT by Chris Dumez
Modified: 2017-11-15 12:43 PST (History)
10 users (show)

See Also:


Attachments
Patch (261.09 KB, patch)
2017-10-27 12:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.21 MB, application/zip)
2017-10-27 13:37 PDT, Build Bot
no flags Details
Patch (263.03 KB, patch)
2017-10-27 13:50 PDT, Chris Dumez
ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Crash Log for fetch-event (58.52 KB, text/plain)
2017-10-30 16:27 PDT, Matt Lewis
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-27 10:29:18 PDT
Unskip more Service Workers tests.
Comment 1 Chris Dumez 2017-10-27 12:32:15 PDT
Created attachment 325184 [details]
Patch
Comment 2 Build Bot 2017-10-27 13:36:59 PDT
Comment on attachment 325184 [details]
Patch

Attachment 325184 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5014129

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html
Comment 3 Build Bot 2017-10-27 13:37:00 PDT
Created attachment 325192 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Chris Dumez 2017-10-27 13:50:09 PDT
Created attachment 325195 [details]
Patch
Comment 5 Geoffrey Garen 2017-10-27 13:57:19 PDT
Comment on attachment 325195 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-10-27 14:36:40 PDT
Comment on attachment 325195 [details]
Patch

Rejecting attachment 325195 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 325195, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
..b1980d7  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 224129 = 8008bc5dd40f489f030622d9a96464995b169b74
r224130 = b1980d74173c702bbd3602c59b81ae63869834b7
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Total errors found: 0 in 1 files

Full output: http://webkit-queues.webkit.org/results/5015058
Comment 7 Chris Dumez 2017-10-27 14:43:48 PDT
Committed r224132: <https://trac.webkit.org/changeset/224132>
Comment 8 Matt Lewis 2017-10-30 16:27:20 PDT
Created attachment 325386 [details]
Crash Log for fetch-event

This patch introduced a flaky crash for the test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.htmlon macOS WK2 platforms:

imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html

first build:
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r224136%20(5579)/results.html
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/5579

The test also is a flaky failure on all platforms.
Comment 9 Radar WebKit Bug Importer 2017-11-15 12:43:15 PST
<rdar://problem/35568009>