Bug 178936 - [GTK][CMake] Incorrect conditional check when adding build dir to GIR runtime library path
Summary: [GTK][CMake] Incorrect conditional check when adding build dir to GIR runtime...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 06:48 PDT by Adrian Perez
Modified: 2017-10-27 10:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2017-10-27 06:52 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-10-27 06:48:08 PDT 
This, in “OptionsGTK.cmake”, around line 1113:

    string(COMPARE EQUAL "${PREV_LOADER_LIBRARY_PATH}" "" ld_library_path_not_exist)
    if (ld_library_path_does_not_exist)
        ...

Notice the different spelling of the variable used for the condition.
Comment 1 Adrian Perez 2017-10-27 06:52:07 PDT 
Created attachment 325158 [details]
Patch
Comment 2 WebKit Commit Bot 2017-10-27 10:33:57 PDT 
Comment on attachment 325158 [details]
Patch

Clearing flags on attachment: 325158

Committed r224118: <https://trac.webkit.org/changeset/224118>
Comment 3 WebKit Commit Bot 2017-10-27 10:33:59 PDT 
All reviewed patches have been landed.  Closing bug.