178933 – Destroy all unneeded anonymous wrappers in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers()

RESOLVED FIXED 178933

Destroy all unneeded anonymous wrappers in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers()

https://bugs.webkit.org/show_bug.cgi?id=178933

Summary Destroy all unneeded anonymous wrappers in RenderObject::removeFromParentAndD...

Antti Koivisto

Reported 2017-10-27 05:01:53 PDT

Currently it just cleans up table related wrappers.

Attachments
patch (2.54 KB, patch) 2017-10-27 05:09 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (267.66 KB, application/zip) 2017-10-27 05:44 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (240.85 KB, application/zip) 2017-10-27 05:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (678.72 KB, application/zip) 2017-10-27 05:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (353.35 KB, application/zip) 2017-10-27 06:11 PDT, Build Bot	no flags	Details
patch (55.42 KB, patch) 2017-10-27 07:32 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (68.22 KB, patch) 2017-10-27 08:52 PDT, Antti Koivisto	zalan: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.86 MB, application/zip) 2017-10-27 09:54 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.10 MB, application/zip) 2017-10-27 10:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (333.70 KB, application/zip) 2017-10-27 10:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.27 MB, application/zip) 2017-10-27 10:44 PDT, Build Bot	no flags	Details
patch (109.22 KB, patch) 2017-10-30 01:51 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (101.83 KB, patch) 2017-10-30 02:12 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (120.36 KB, patch) 2017-10-30 03:27 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-10-27 05:09:12 PDT

Created attachment 325149 [details] patch

Build Bot

Comment 2 2017-10-27 05:44:20 PDT

Comment on attachment 325149 [details] patch Attachment 325149 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5010861 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2017-10-27 05:44:21 PDT

Created attachment 325151 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-10-27 05:48:15 PDT

Comment on attachment 325149 [details] patch Attachment 325149 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5010855 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2017-10-27 05:48:16 PDT

Created attachment 325152 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-10-27 05:48:32 PDT

Comment on attachment 325149 [details] patch Attachment 325149 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5010858 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2017-10-27 05:48:33 PDT

Created attachment 325153 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-10-27 06:11:35 PDT

Comment on attachment 325149 [details] patch Attachment 325149 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5010870 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-10-27 06:11:36 PDT

Created attachment 325156 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Antti Koivisto

Comment 10 2017-10-27 07:32:18 PDT

Created attachment 325160 [details] patch

Antti Koivisto

Comment 11 2017-10-27 08:52:33 PDT

Created attachment 325164 [details] patch

Build Bot

Comment 12 2017-10-27 09:54:40 PDT

Comment on attachment 325164 [details] patch Attachment 325164 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5011469 New failing tests: fast/forms/button-generated-content.html

Build Bot

Comment 13 2017-10-27 09:54:42 PDT

Created attachment 325168 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 14 2017-10-27 10:35:07 PDT

Comment on attachment 325164 [details] patch Attachment 325164 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5012195 New failing tests: fast/forms/button-generated-content.html

Build Bot

Comment 15 2017-10-27 10:35:09 PDT

Created attachment 325174 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 16 2017-10-27 10:35:14 PDT

Comment on attachment 325164 [details] patch Attachment 325164 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5012139 Number of test failures exceeded the failure limit.

Build Bot

Comment 17 2017-10-27 10:35:16 PDT

Created attachment 325175 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Build Bot

Comment 18 2017-10-27 10:44:11 PDT

Comment on attachment 325164 [details] patch Attachment 325164 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5012228 New failing tests: fast/forms/button-generated-content.html

Build Bot

Comment 19 2017-10-27 10:44:13 PDT

Created attachment 325176 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 20 2017-10-30 01:51:48 PDT

Created attachment 325342 [details] patch

Antti Koivisto

Comment 21 2017-10-30 02:12:19 PDT

Created attachment 325344 [details] patch

Antti Koivisto

Comment 22 2017-10-30 03:27:56 PDT

Created attachment 325345 [details] patch

Antti Koivisto

Comment 23 2017-10-30 04:14:28 PDT

https://trac.webkit.org/r224177

Carlos Alberto Lopez Perez

Comment 24 2017-10-30 06:39:37 PDT

Committed r224178: <https://trac.webkit.org/changeset/224178>

Radar WebKit Bug Importer

Comment 25 2017-11-15 12:41:14 PST

<rdar://problem/35567870>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Layout and Rendering

Assignee

Nobody

Reported

2017-10-27 05:01 PDT

Modified

2017-11-15 12:41 PST History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks