Bug 178926 – Plumbing for handling Service Worker scripts failing to evaluate

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Reject SW registrations where the script fails to evaluate

[Brady Eidson]

Created attachment 325136 [details]
WIP

Quick EWS run to verify no change in current tested behavior while I work on test for the new behavior

[Build Bot]

Comment on attachment 325136 [details]
WIP

Attachment 325136 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5010023

New failing tests:
fast/workers/worker-script-error.html
http/tests/workers/worker-importScriptsOnError.html

[Build Bot]

Created attachment 325143 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 325136 [details]
WIP

Attachment 325136 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5010058

New failing tests:
fast/workers/worker-script-error.html
http/tests/workers/worker-importScriptsOnError.html

[Build Bot]

Created attachment 325145 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 325136 [details]
WIP

Attachment 325136 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5010121

New failing tests:
fast/workers/worker-script-error.html
http/tests/workers/worker-importScriptsOnError.html

[Build Bot]

Created attachment 325147 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Build Bot]

Comment on attachment 325136 [details]
WIP

Attachment 325136 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5010562

New failing tests:
fast/workers/worker-script-error.html
http/tests/workers/worker-importScriptsOnError.html

[Build Bot]

Created attachment 325148 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Brady Eidson]

Subtle mistake! New patch incoming.

[Brady Eidson]

Created attachment 325170 [details]
Another EWS run

[Chris Dumez]

(In reply to Brady Eidson from comment #11)
> Created attachment 325170 [details]
> Another EWS run

Fails to apply. Might be because of me, sorry.

[Brady Eidson]

Created attachment 325189 [details]
For EWS

[Build Bot]

Attachment 325189 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/SWContextManager.h:47:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

(In reply to Chris Dumez from comment #12)
> (In reply to Brady Eidson from comment #11)
> > Created attachment 325170 [details]
> > Another EWS run
> 
> Fails to apply. Might be because of me, sorry.

YUP.

That's fine.

[Brady Eidson]

Going to back burner this, because it's actually not right (We just re-read the Install algorithm and found some out of orderness)

It will be needed soon, though.

[Brady Eidson]

Rename: Handling SW scripts failing to evaluate

[Brady Eidson]

Created attachment 325623 [details]
Patch

[Chris Dumez]

Comment on attachment 325623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325623&action=review

r=me assuming the bots are happy.

> Source/WebCore/workers/WorkerThread.cpp:190
> +    if (m_hasEvaluateCallback) {

This is just to avoid a dispatch? If so, I am personally not sure it is worth an extra member. We could do inside the lambda:
if (evaluateCallback)
    evaluateCallback(message);

[Brady Eidson]

Created attachment 325628 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 325628 [details]
Patch

Clearing flags on attachment: 325628

Committed r224295: <https://trac.webkit.org/changeset/224295>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568025>