Bug 178895 - Web Automation: denying user permission for getUserMedia doesn't work
Summary: Web Automation: denying user permission for getUserMedia doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-26 16:46 PDT by Brian Burg
Modified: 2017-10-26 19:32 PDT (History)
5 users (show)

See Also:


Attachments
Proposed Fix (3.35 KB, patch)
2017-10-26 16:50 PDT, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-10-26 16:46:31 PDT
The ordering of special cases is incorrect. Our hardcoded "allow mock devices and don't prompt for them" settings are short-circuiting the automation session's getUserMedia permission check.
Comment 1 Brian Burg 2017-10-26 16:46:42 PDT
rdar://problem/35210121
Comment 2 Brian Burg 2017-10-26 16:50:35 PDT
Created attachment 325079 [details]
Proposed Fix
Comment 3 youenn fablet 2017-10-26 16:53:25 PDT
LGTM.
At some point, we might want to remove mockCaptureDevicesPromptEnabled since WebDriver is a better solution.
Comment 4 WebKit Commit Bot 2017-10-26 19:32:07 PDT
Comment on attachment 325079 [details]
Proposed Fix

Clearing flags on attachment: 325079

Committed r224082: <https://trac.webkit.org/changeset/224082>
Comment 5 WebKit Commit Bot 2017-10-26 19:32:08 PDT
All reviewed patches have been landed.  Closing bug.