Bug 178892 - Modernize AccessibilityObject.h
Summary: Modernize AccessibilityObject.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-26 16:20 PDT by Alex Christensen
Modified: 2017-11-15 12:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (307.53 KB, patch)
2017-10-26 16:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (327.94 KB, patch)
2017-10-26 16:52 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (338.52 KB, patch)
2017-10-26 17:09 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (346.47 KB, patch)
2017-10-26 17:22 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (347.90 KB, patch)
2017-10-26 17:29 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (98.20 KB, patch)
2017-10-26 19:14 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-26 16:20:50 PDT 
Modernize AccessibilityObject.h
Comment 1 Alex Christensen 2017-10-26 16:24:31 PDT 
Created attachment 325075 [details]
Patch
Comment 2 Alex Christensen 2017-10-26 16:52:00 PDT 
Created attachment 325080 [details]
Patch
Comment 3 Alex Christensen 2017-10-26 17:09:55 PDT 
Created attachment 325081 [details]
Patch
Comment 4 Alex Christensen 2017-10-26 17:22:25 PDT 
Created attachment 325082 [details]
Patch
Comment 5 Alex Christensen 2017-10-26 17:29:32 PDT 
Created attachment 325084 [details]
Patch
Comment 6 Alex Christensen 2017-10-26 17:37:25 PDT 
http://trac.webkit.org/r224074
Comment 8 Michael Catanzaro 2017-10-26 19:02:43 PDT 
Committed r224079: <https://trac.webkit.org/changeset/224079>
Comment 9 Keith Miller 2017-10-26 19:14:23 PDT 
Reopening to attach new patch.
Comment 10 Keith Miller 2017-10-26 19:14:24 PDT 
Created attachment 325098 [details]
Patch
Comment 11 Alex Christensen 2017-10-26 19:45:32 PDT 
http://trac.webkit.org/r224083
Keith attached a patch to the wrong bug :(
Comment 12 Keith Miller 2017-10-26 19:47:20 PDT 
(In reply to Alex Christensen from comment #11)
> http://trac.webkit.org/r224083
> Keith attached a patch to the wrong bug :(

Man, webkit-patch has not been my friend today... :(
Comment 13 Ryan Haddad 2017-10-27 09:18:43 PDT 
accessibility/mac/aria-label-on-label-element.html is failing after this change:

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/accessibility/mac/aria-label-on-label-element-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/accessibility/mac/aria-label-on-label-element-actual.txt
@@ -12,7 +12,7 @@
 PASS !titleUIElement1 is true
 PASS input1.title is 'AXTitle: aria label'
 PASS titleUIElement2.isEqual(accessibilityController.accessibleElementById('label2')) is true
-PASS input3.title is 'AXTitle: hidden aria label'
+FAIL input3.title should be AXTitle: hidden aria label. Was AXTitle: .
 PASS input4.title is 'AXTitle: aria labelledby'
 PASS successfullyParsed is true

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Faria-label-on-label-element.html
Comment 14 Alex Christensen 2017-10-27 10:39:29 PDT 
http://trac.webkit.org/r224119
Comment 15 Radar WebKit Bug Importer 2017-11-15 12:41:54 PST 
<rdar://problem/35567968>