We should be using “CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE()” to give “libWPEWebKit.so” a proper shared object version. There's a macro for this in “Source/cmake/OptionsGTK.cmake” which could be moved to a common location and then used by both the GTK+ and WPE ports.
Created attachment 325032 [details] Patch
Comment on attachment 325032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325032&action=review > Source/cmake/OptionsWPE.cmake:4 > +SET_PROJECT_VERSION(2 19 0) Please use 0 19 0 for WPE, like we discussed internally today. We can always raise the first version later, and I absolutely plan to do that, but for now keeping a leading 0 would be nice to indicate it's still unstable. Alternatively, if you prefer, you could add an optional nano version (that would not be used for WebKitGTK+) and make it 0 2 19 0. Maybe that would be the least-confusing option.
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 325032 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=325032&action=review > > > Source/cmake/OptionsWPE.cmake:4 > > +SET_PROJECT_VERSION(2 19 0) > > Please use 0 19 0 for WPE, like we discussed internally today. We can always > raise the first version later, and I absolutely plan to do that, but for now > keeping a leading 0 would be nice to indicate it's still unstable. Oh, this slipped out from the patch. I'll fix and re-upload. > Alternatively, if you prefer, you could add an optional nano version (that > would not be used for WebKitGTK+) and make it 0 2 19 0. Maybe that would be > the least-confusing option. I think three version numbers are more than enough. It's fine having zero as major for now, because in the longer term we'll make them converge.
Created attachment 325048 [details] Patch for landing
Comment on attachment 325048 [details] Patch for landing Clearing flags on attachment: 325048 Committed r224047: <https://trac.webkit.org/changeset/224047>
All reviewed patches have been landed. Closing bug.