Bug 178876 - Bring back SWContextManager abstraction in WebCore
Summary: Bring back SWContextManager abstraction in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 178794
  Show dependency treegraph
 
Reported: 2017-10-26 10:44 PDT by Chris Dumez
Modified: 2017-11-15 12:51 PST (History)
5 users (show)

See Also:


Attachments
Patch (60.31 KB, patch)
2017-10-26 12:06 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (60.35 KB, patch)
2017-10-26 12:22 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-26 10:44:21 PDT
Bring back SWContextManager abstraction in WebCore. It was killed in <https://trac.webkit.org/changeset/223718> but is actually useful when the ServiceWorker wants to message the storage process.
Comment 1 Chris Dumez 2017-10-26 12:06:40 PDT
Created attachment 325038 [details]
Patch
Comment 2 Chris Dumez 2017-10-26 12:22:52 PDT
Created attachment 325040 [details]
Patch
Comment 3 Geoffrey Garen 2017-10-26 12:54:19 PDT
Comment on attachment 325040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325040&action=review

r=me

> Source/WebCore/workers/service/context/SWContextManager.cpp:68
> +    // FIXME: We should pass valid MessagePortChannels.

Can you add a bug for this?

> Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:99
> +    // FIXME: Provide a sensical session ID.

And this?
Comment 4 WebKit Commit Bot 2017-10-26 13:14:44 PDT
Comment on attachment 325040 [details]
Patch

Clearing flags on attachment: 325040

Committed r224041: <https://trac.webkit.org/changeset/224041>
Comment 5 WebKit Commit Bot 2017-10-26 13:14:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:51:57 PST
<rdar://problem/35568303>