Bug 178874 – Demonstrate a possible structure of the WebGPU API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Demonstrate a possible structure of the WebGPU API

[Myles C. Maxfield]

Created attachment 325024 [details]
Patch

[Build Bot]

Attachment 325024 [details] did not pass style-queue:


ERROR: Unexpected diff format when parsing a chunk: 'The file will have its original line endings in your working directory.'
ERROR: Unexpected diff format when parsing a chunk: 'nformation>true</GenerateDebugInformation>'
ERROR: Tools/ChangeLog:77:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:78:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:79:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:80:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:81:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:82:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:83:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:84:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:179:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:180:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:181:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 11 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

Created attachment 325035 [details]
Patch

[Dean Jackson]

Comment on attachment 325035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325035&action=review

> Tools/ChangeLog:11
> +        Over the past few weeks, we've been putting together an example showing that a WebGPU API
> +        which has implicit barriers can work on all three low-level graphics APIs. We've implemented
> +        it on top of Vulkan first, because this is the API which has the strictest requirements and
> +        is most difficult to use.

I think most of this ChangeLog should go in a README.txt file, because it is both useful and something you'd want to refer to directly within the project.

[Myles C. Maxfield]

Comment on attachment 325035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325035&action=review

>> Tools/ChangeLog:11
>> +        is most difficult to use.
> 
> I think most of this ChangeLog should go in a README.txt file, because it is both useful and something you'd want to refer to directly within the project.

Yep! I will make it a .md file.

[WebKit Commit Bot]

Comment on attachment 325035 [details]
Patch

Rejecting attachment 325035 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 325035, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
sing rebase:
:040000 040000 883c0b3ecf28c0344a8fb3de466ce9bec4b4de14 b307e97f51fcd059a31d836192577582eebdf63a M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/5001765

[Myles C. Maxfield]

Committed r224065: <https://trac.webkit.org/changeset/224065>

[Radar WebKit Bug Importer]

<rdar://problem/35568310>