Bug 178847 - Unified sources for FEMorphology.cpp seems to break the windows build.
Summary: Unified sources for FEMorphology.cpp seems to break the windows build.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 21:22 PDT by Keith Miller
Modified: 2018-01-30 13:56 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.24 KB, patch)
2018-01-30 01:28 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (4.12 KB, patch)
2018-01-30 02:45 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-10-25 21:22:46 PDT
Relevant build error (not really sure what the problem is):

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(171): error C2079: 'parallelJobs' uses undefined class 'WebCore::ParallelJobs<WebCore::FEMorphology::PlatformApplyParameters>' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(171): error C2440: 'initializing': cannot convert from 'initializer list' to 'int' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(171): note: The initializer contains too many elements (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp)
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(172): error C2228: left of '.numberOfJobs' must have class/struct/union (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(172): note: type is 'int' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp)
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(180): error C2228: left of '.parameter' must have class/struct/union (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(180): note: type is 'int' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp)
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(180): error C2530: 'param': references must be initialized (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(187): error C2228: left of '.execute' must have class/struct/union (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform/graphics/filters/FEMorphology.cpp(187): note: type is 'int' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource316.cpp)
Comment 1 Fujii Hironori 2018-01-30 01:24:07 PST
I see different compilation error.
I built AppleWin port and WinCairo port.

> Source\WebCore\platform/graphics/filters/SpotLightSource.cpp(45): error C2027: use of undefined type 'WebCore::FilterEffect'
> source\webcore\platform\graphics\filters\LightSource.h(41): note: see declaration of 'WebCore::FilterEffect'
> Source\WebCore\platform/graphics/filters/SpotLightSource.cpp(45): error C2228: left of '.mapPointFromUserSpaceToBuffer' must have class/struct/union
> Source\WebCore\platform/graphics/filters/SpotLightSource.cpp(47): error C2027: use of undefined type 'WebCore::FilterEffect'
> source\webcore\platform\graphics\filters\LightSource.h(41): note: see declaration of 'WebCore::FilterEffect'
> Source\WebCore\platform/graphics/filters/SpotLightSource.cpp(47): error C2228: left of '.mapPointFromUserSpaceToBuffer' must have class/struct/union
Comment 2 Fujii Hironori 2018-01-30 01:28:43 PST
Created attachment 332637 [details]
Patch
Comment 3 Fujii Hironori 2018-01-30 02:45:46 PST
Created attachment 332643 [details]
Patch
Comment 4 Yusuke Suzuki 2018-01-30 07:29:56 PST
Comment on attachment 332643 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-01-30 13:55:17 PST
Comment on attachment 332643 [details]
Patch

Clearing flags on attachment: 332643

Committed r227849: <https://trac.webkit.org/changeset/227849>
Comment 6 WebKit Commit Bot 2018-01-30 13:55:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-30 13:56:40 PST
<rdar://problem/37042024>