Bug 178846 - Add inspector logging for MediaElementSession autoplay
Summary: Add inspector logging for MediaElementSession autoplay
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 21:21 PDT by youenn fablet
Modified: 2017-11-15 12:43 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.00 KB, patch)
2017-10-25 21:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.56 KB, patch)
2017-10-26 10:39 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-10-25 21:21:24 PDT 
This is often a place where devs have difficulties
Comment 1 youenn fablet 2017-10-25 21:23:45 PDT 
Created attachment 324953 [details]
Patch
Comment 2 Eric Carlson 2017-10-26 05:21:53 PDT 
Comment on attachment 324953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324953&action=review

> Source/WebCore/html/MediaElementSession.cpp:112
> +    , m_logIdentifier(reinterpret_cast<const void*>(cryptographicallyRandomNumber()))

I think it would be better to use the media element’s identifier, so it will be easier to understand logging for pages with more than one element.

> Source/WebCore/html/MediaElementSession.cpp:846
> +bool MediaElementSession::willLog(WTFLogLevel level) const

Is it possible to just use the media element method?

> Source/WebCore/html/MediaElementSession.cpp:857
> +WTFLogChannel& MediaElementSession::logChannel() const

Ditto.
Comment 3 youenn fablet 2017-10-26 10:39:32 PDT 
Created attachment 325027 [details]
Patch
Comment 4 youenn fablet 2017-10-26 10:40:11 PDT 
Thanks for the review.
I updated patch accordingly.
Comment 5 WebKit Commit Bot 2017-10-26 11:38:58 PDT 
Comment on attachment 325027 [details]
Patch

Clearing flags on attachment: 325027

Committed r224030: <https://trac.webkit.org/changeset/224030>
Comment 6 WebKit Commit Bot 2017-10-26 11:38:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 12:43:54 PST 
<rdar://problem/35568039>