This is often a place where devs have difficulties
Created attachment 324953 [details] Patch
Comment on attachment 324953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324953&action=review > Source/WebCore/html/MediaElementSession.cpp:112 > + , m_logIdentifier(reinterpret_cast<const void*>(cryptographicallyRandomNumber())) I think it would be better to use the media element’s identifier, so it will be easier to understand logging for pages with more than one element. > Source/WebCore/html/MediaElementSession.cpp:846 > +bool MediaElementSession::willLog(WTFLogLevel level) const Is it possible to just use the media element method? > Source/WebCore/html/MediaElementSession.cpp:857 > +WTFLogChannel& MediaElementSession::logChannel() const Ditto.
Created attachment 325027 [details] Patch
Thanks for the review. I updated patch accordingly.
Comment on attachment 325027 [details] Patch Clearing flags on attachment: 325027 Committed r224030: <https://trac.webkit.org/changeset/224030>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35568039>