This is often a place where devs have difficulties
Created attachment 324953 [details]
Comment on attachment 324953 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=324953&action=review
> + , m_logIdentifier(reinterpret_cast<const void*>(cryptographicallyRandomNumber()))
I think it would be better to use the media element’s identifier, so it will be easier to understand logging for pages with more than one element.
> +bool MediaElementSession::willLog(WTFLogLevel level) const
Is it possible to just use the media element method?
> +WTFLogChannel& MediaElementSession::logChannel() const
Created attachment 325027 [details]
Thanks for the review.
I updated patch accordingly.
Comment on attachment 325027 [details]
Clearing flags on attachment: 325027
Committed r224030: <https://trac.webkit.org/changeset/224030>
All reviewed patches have been landed. Closing bug.