Bug 178844 - WPE does not build with DragImage.cpp in unified sources.
Summary: WPE does not build with DragImage.cpp in unified sources.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 20:50 PDT by Keith Miller
Modified: 2017-11-17 12:37 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.62 KB, patch)
2017-10-31 18:12 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (6.52 KB, patch)
2017-11-01 10:39 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-10-25 20:50:05 PDT
It looks like this is happening because WPE doesn't have a DragImageWPE.cpp file.
Comment 1 Michael Catanzaro 2017-10-31 18:12:11 PDT
Created attachment 325533 [details]
Patch
Comment 2 Michael Catanzaro 2017-11-01 05:56:51 PDT
Comment on attachment 325533 [details]
Patch

Well I got WPE working, but looks like it broke macOS and iOS. I don't plan to debug that. :)
Comment 3 Keith Miller 2017-11-01 08:41:49 PDT
Oh, the fix for iOS/Mac is to delete the lines that say "DragImage.cpp in Sources" in WebCore.xcodeproj/proj.pbxproj
Comment 4 Michael Catanzaro 2017-11-01 10:39:45 PDT
Created attachment 325587 [details]
Patch
Comment 5 Michael Catanzaro 2017-11-01 11:24:29 PDT
Looks like it works. mac-debug might be about to complain about a flaky test, though.
Comment 6 Keith Miller 2017-11-02 08:58:35 PDT
Comment on attachment 325587 [details]
Patch

r=me.
Comment 7 WebKit Commit Bot 2017-11-02 10:13:37 PDT
Comment on attachment 325587 [details]
Patch

Clearing flags on attachment: 325587

Committed r224339: <https://trac.webkit.org/changeset/224339>
Comment 8 WebKit Commit Bot 2017-11-02 10:13:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-11-17 12:37:28 PST
<rdar://problem/35621445>