Bug 178843 - Remove code to update block selection
Summary: Remove code to update block selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 20:27 PDT by Megan Gardner
Modified: 2017-10-26 11:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (18.11 KB, patch)
2017-10-25 20:31 PDT, Megan Gardner 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-10-25 20:27:55 PDT 
Remove code to update block selection
Comment 1 Megan Gardner 2017-10-25 20:31:57 PDT 
Created attachment 324949 [details]
Patch
Comment 2 Tim Horton 2017-10-25 20:39:20 PDT 
Comment on attachment 324949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324949&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3960
> +    if ((!_selectionNeedsUpdate) || (_page->editorState().isMissingPostLayoutData))

Too many parens. Also, this should be in its own patch! Possibly with a test :)

r=me for the rest.
Comment 3 Radar WebKit Bug Importer 2017-10-25 23:04:32 PDT 
<rdar://problem/35191802>
Comment 4 Megan Gardner 2017-10-26 11:20:50 PDT 
https://trac.webkit.org/r224029