WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
178843
Remove code to update block selection
https://bugs.webkit.org/show_bug.cgi?id=178843
Summary
Remove code to update block selection
Megan Gardner
Reported
2017-10-25 20:27:55 PDT
Remove code to update block selection
Attachments
Patch
(18.11 KB, patch)
2017-10-25 20:31 PDT
,
Megan Gardner
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2017-10-25 20:31:57 PDT
Created
attachment 324949
[details]
Patch
Tim Horton
Comment 2
2017-10-25 20:39:20 PDT
Comment on
attachment 324949
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=324949&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3960 > + if ((!_selectionNeedsUpdate) || (_page->editorState().isMissingPostLayoutData))
Too many parens. Also, this should be in its own patch! Possibly with a test :) r=me for the rest.
Radar WebKit Bug Importer
Comment 3
2017-10-25 23:04:32 PDT
<
rdar://problem/35191802
>
Megan Gardner
Comment 4
2017-10-26 11:20:50 PDT
https://trac.webkit.org/r224029
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug