Bug 178841 - Rebase contentextensions test expectations
Summary: Rebase contentextensions test expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-25 18:16 PDT by Alex Christensen
Modified: 2017-11-15 12:44 PST (History)
1 user (show)

See Also:

Attachments
Patch (14.03 KB, patch)
2017-10-25 18:17 PDT, Alex Christensen 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-25 18:16:13 PDT 
Rebase contentextensions test expectations
Comment 1 Alex Christensen 2017-10-25 18:17:44 PDT 
Created attachment 324936 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-10-25 19:10:55 PDT 
Comment on attachment 324936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324936&action=review

> LayoutTests/http/tests/contentextensions/block-everything-if-domain-expected.txt:2
> +layer at (0,0) size 800x600

These changes are a bit suspicious, was there actually something known that would cause this?
Comment 3 Alex Christensen 2017-10-26 11:40:14 PDT 
Comment on attachment 324936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324936&action=review

>> LayoutTests/http/tests/contentextensions/block-everything-if-domain-expected.txt:2
>> +layer at (0,0) size 800x600
> 
> These changes are a bit suspicious, was there actually something known that would cause this?

I'm not sure what would've caused this.  It would've been nice to hot have these tests marked as flaky so we could've noticed that change.  The important part of the test is that the console message is printed, and these results verify that that is still the case, so I think the test is still good.
Comment 4 Alex Christensen 2017-10-26 11:41:55 PDT 
http://trac.webkit.org/r224031
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:44:39 PST 
<rdar://problem/35568072>